Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RelayMiner] Support https backend urls #507

Merged
merged 2 commits into from
Apr 26, 2024
Merged

[RelayMiner] Support https backend urls #507

merged 2 commits into from
Apr 26, 2024

Conversation

red-0ne
Copy link
Contributor

@red-0ne red-0ne commented Apr 26, 2024

Summary

Make RelayMiner support forwarding relay requests to https backends.

It infers the protocol to use from the backend_url schema and constructs the appropriate client.

Updates the RelayMiner config parser and make it accept https backend urls.

Issue

The RelayMiner is not capable of forwarding relay requests to https backend_urls, which is a quite widespread setup among node runners.

#499 (comment)

image

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

Local Testing (only if making code changes)

  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • See quickstart guide for instructions

PR Testing (only if making code changes)

  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
    • THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
    • Optionally run make trigger_ci if you want to re-trigger tests without any code changes
    • If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@red-0ne red-0ne added relayminer Changes related to the Relayminer off-chain Off-chain business logic labels Apr 26, 2024
@red-0ne red-0ne added this to the Shannon Public TestNet milestone Apr 26, 2024
@red-0ne red-0ne requested review from Olshansk and okdas April 26, 2024 23:39
@red-0ne red-0ne self-assigned this Apr 26, 2024
Copy link
Member

@okdas okdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick, let's sneak this PR in before @Olshansk turns around! 😄🕵️‍♂️

@red-0ne red-0ne merged commit aba098d into main Apr 26, 2024
11 checks passed
bryanchriswhite added a commit that referenced this pull request Apr 29, 2024
…cept

* pokt/main:
  [Dashboard] Supplier logs dashboard (#502)
  [Utility] Update SessionSettlement when app goes into a negative amount (#509)
  [Testing] Supplier staking E2E test (#498)
  [RelayMiner] Support https backend urls (#507)
  [Bug] Fix pprof endpoint (#505)
  [LocalNet] Remove tilt-restart-wrapper (#504)
  [LocalNet][Hotfix] Turn off pproff by default (#500)
  [Tooling] Add pprof endpoints and documentation (#484)
  [Documentation] Basic blockchain operations (#454)
  [BlockClient] Refactor BlockClient to fetch latest block at init (#444)
@Olshansk Olshansk deleted the feat/https-backend branch May 29, 2024 16:44
okdas pushed a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
off-chain Off-chain business logic relayminer Changes related to the Relayminer
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants