[Application] feat: app stake transfer #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
application
bryanchriswhite
force-pushed
the
issues/657/feat/app-stake-transfer
branch
2 times, most recently
from
dba612f to
091fbb4
Compare
bryanchriswhite
commented
Aug 17, 2024
bryanchriswhite
force-pushed
the
issues/657/feat/app-stake-transfer
branch
from
3b7d2a8 to
51f70f9
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bryanchriswhite
force-pushed
the
issues/657/feat/app-stake-transfer
branch
from
51f70f9 to
ab8f0cc
Compare
This comment was marked as resolved.
This comment was marked as resolved.
bryanchriswhite
force-pushed
the
issues/657/feat/app-stake-transfer
branch
from
2e4e7f5 to
84b7441
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
bryanchriswhite
force-pushed
the
issues/657/feat/app-stake-transfer
branch
from
e1c8318 to
69a7b03
Compare
bryanchriswhite
changed the base branch from
main
to
issues/405/fix/pulsar-imports
bryanchriswhite
force-pushed
the
issues/657/feat/app-stake-transfer
branch
from
69a7b03 to
9da8ff4
Compare
bryanchriswhite
added
push-image
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 743) |
|
The image is going to be pushed after the next commit. You can use If you also want to run E2E tests, please add |
bryanchriswhite
commented
Aug 22, 2024
bryanchriswhite
commented
Aug 22, 2024
…eficiary:string --module application
bryanchriswhite
force-pushed
the
issues/657/feat/app-stake-transfer
branch
from
fcd66fc to
709569c
Compare
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 743) |
Olshansk
approved these changes
Sep 20, 2024
bryanchriswhite
added a commit
that referenced
this pull request
Sep 23, 2024
## Summary - Renaming the application module `TransferApplicationStake` messages to `TransferApplication` ## Depends on - #743 ## Dependents - #789 ## Issue - #657 ## Type of change Select one or more: - [ ] New feature, functionality or library - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [ ] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]>
bryanchriswhite
added a commit
that referenced
this pull request
Sep 23, 2024
…lier-stake-events * issues/799/e2e/param-helpers: fix: add missing steps and update module name for moved param [Code Health] refactor: rename `ApplicationTransfer` msgs (#788) [Docs] Add operations documentation about proof submission fee (#806) [Testing] Fix non-idempotency in (and speed up) supplier staking tests (#815) [Application] feat: app stake transfer (#743) Empty commit [Tokenomics] Preparation for proportional relay mining rewards based on difficulty (#771) [Documentation] Change container names in the quickstart (#830)
bryanchriswhite
added a commit
that referenced
this pull request
Sep 23, 2024
…merge/integration-app_x_sup-stake-evts * issues/799/feat/supplier-stake-events: fix: add missing steps and update module name for moved param [Code Health] refactor: rename `ApplicationTransfer` msgs (#788) [Docs] Add operations documentation about proof submission fee (#806) [Testing] Fix non-idempotency in (and speed up) supplier staking tests (#815) [Application] feat: app stake transfer (#743) Empty commit chore: review feedback improvements
bryanchriswhite
added a commit
that referenced
this pull request
Sep 23, 2024
… issues/799/tests/params * issues/799/merge/integration-app_x_sup-stake-evts: fix: add missing steps and update module name for moved param [Code Health] refactor: rename `ApplicationTransfer` msgs (#788) [Docs] Add operations documentation about proof submission fee (#806) [Testing] Fix non-idempotency in (and speed up) supplier staking tests (#815) [Application] feat: app stake transfer (#743) Empty commit chore: review feedback improvements
bryanchriswhite
added a commit
that referenced
this pull request
Sep 23, 2024
…ues/657/merge/integration-app_x_transfer-period-base * issues/657/refactor/transfer-msg_period-param: [Application] feat: app stake transfer (#743) Empty commit
bryanchriswhite
added a commit
that referenced
this pull request
Sep 23, 2024
…' into issues/657/chore/app-transfer-period * issues/657/merge/integration-app_x_transfer-period-base: [Application] feat: app stake transfer (#743) Empty commit
bryanchriswhite
added a commit
that referenced
this pull request
Oct 4, 2024
## Summary - Reconcile the need for a transfer period with #743. - Ensure the app transfer message handler returns grpc status errors consistently. - Improve some shared E2E tests. - Implement `ApplicationIntegrationSuite` test suite. - Port app transfer E2E tests to integration tests. ## Depends on - #827 - #788 - #743 ## Issue - #657 ## Type of change Select one or more: - [x] New feature, functionality or library - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing <!-- READ & DELETE: - Documentation changes: only keep this if you're making documentation changes - Unit Testing: Remove this if you didn't make code changes - E2E Testing: Remove this if you didn't make code changes - See the quickstart guide for instructions: https://dev.poktroll.com/developer_guide/quickstart - DevNet E2E Testing: Remove this if you didn't make code changes - THIS IS VERY EXPENSIVE: only do it after all the reviews are complete. - Optionally run `make trigger_ci` if you want to re-trigger tests without any code changes - If tests fail, try re-running failed tests only using the GitHub UI as shown [here](https://github.com/pokt-network/poktroll/assets/1892194/607984e9-0615-4569-9452-4c730190c1d2) --> - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [x] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: Redouane Lakrache <[email protected]> Co-authored-by: red-0ne <[email protected]>
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Summary - Add `MsgTransferApplicationStake`. - Implement application stake transfer to new "beneficiary" application (unstakes original application). ## Dependents - #788 - #789 ## Issue - #657 ## Type of change Select one or more: - [x] New feature, functionality or library - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing **Documentation changes** (only if making doc changes) - [ ] `make docusaurus_start`; only needed if you make doc changes **Local Testing** (only if making code changes) - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - See [quickstart guide](https://dev.poktroll.com/developer_guide/quickstart) for instructions **PR Testing** (only if making code changes) - [x] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. - **THIS IS VERY EXPENSIVE**, so only do it after all the reviews are complete. - Optionally run `make trigger_ci` if you want to re-trigger tests without any code changes - If tests fail, try re-running failed tests only using the GitHub UI as shown [here](https://github.com/pokt-network/poktroll/assets/1892194/607984e9-0615-4569-9452-4c730190c1d2) ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]>
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Summary - Renaming the application module `TransferApplicationStake` messages to `TransferApplication` ## Depends on - #743 ## Dependents - #789 ## Issue - #657 ## Type of change Select one or more: - [ ] New feature, functionality or library - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [ ] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]>
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Summary - Reconcile the need for a transfer period with #743. - Ensure the app transfer message handler returns grpc status errors consistently. - Improve some shared E2E tests. - Implement `ApplicationIntegrationSuite` test suite. - Port app transfer E2E tests to integration tests. ## Depends on - #827 - #788 - #743 ## Issue - #657 ## Type of change Select one or more: - [x] New feature, functionality or library - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing <!-- READ & DELETE: - Documentation changes: only keep this if you're making documentation changes - Unit Testing: Remove this if you didn't make code changes - E2E Testing: Remove this if you didn't make code changes - See the quickstart guide for instructions: https://dev.poktroll.com/developer_guide/quickstart - DevNet E2E Testing: Remove this if you didn't make code changes - THIS IS VERY EXPENSIVE: only do it after all the reviews are complete. - Optionally run `make trigger_ci` if you want to re-trigger tests without any code changes - If tests fail, try re-running failed tests only using the GitHub UI as shown [here](https://github.com/pokt-network/poktroll/assets/1892194/607984e9-0615-4569-9452-4c730190c1d2) --> - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [x] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: Redouane Lakrache <[email protected]> Co-authored-by: red-0ne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MsgTransferApplicationStake.Dependents
ApplicationTransfermsgs #788Issue
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_testmake test_e2ePR Testing (only if making code changes)
devnet-test-e2elabel to the PR.make trigger_ciif you want to re-trigger tests without any code changesSanity Checklist