Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve packaged Linux binary performance #1755

Merged
merged 1 commit into from
Mar 25, 2017
Merged

Improve packaged Linux binary performance #1755

merged 1 commit into from
Mar 25, 2017

Conversation

SeanTAllen
Copy link
Member

No description provided.

@SeanTAllen SeanTAllen added the do not merge This PR should not be merged at this time label Mar 25, 2017
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Mar 25, 2017
@SeanTAllen
Improve packaged Linux binary performance
fda43a3 
In order to address problems on older CPUs with "illegal instruction"
errors, we set the target CPU to x86-64 for Deb and RPM release builds.
Original issue is #1682 and the PR to implement was #1686.

As part of #1682, we discussed that we should also build using
-mtune=intel to get better performance.
@SeanTAllen SeanTAllen removed the do not merge This PR should not be merged at this time label Mar 25, 2017
@SeanTAllen SeanTAllen requested a review from killerswan March 25, 2017 02:21
@SeanTAllen SeanTAllen changed the title Verify travis tune problem Improve packaged Linux binary performance Mar 25, 2017
@SeanTAllen
Copy link
Member Author

FYI, I first tested this using the test-ci make task before amending the commit to only do on release and deploy.

@killerswan
Copy link
Member

If you're saying there's a travis build which confirms that this works, can you hyperlink it here?

Anyways I'm inclined to merge it now anyways...

@SeanTAllen
Copy link
Member Author

@killerswan https://travis-ci.org/ponylang/ponyc/builds/214875040

@killerswan
Copy link
Member

Ahh, cool. So that was a run for an earlier commit of the pull req. (which travis saw as 8a2b399) and where make CC="$CC1" CXX="$CXX1" tune=intel test-ci worked.

@killerswan killerswan merged commit e248c3b into master Mar 25, 2017
ponylang-main added a commit that referenced this pull request Mar 25, 2017
@ponylang-main
Update CHANGELOG for PR #1755 [skip ci]
0a0e7ef
@SeanTAllen SeanTAllen deleted the travis-test branch March 25, 2017 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killerswan killerswan Awaiting requested review from killerswan

Assignees
No one assigned
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeanTAllen @killerswan