-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Google Benchmark to v1.5.0 #3386
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
--- | ||
Language: Cpp | ||
BasedOnStyle: Google | ||
PointerAlignment: Left | ||
... | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,15 +9,20 @@ | |
# Please keep the list sorted. | ||
|
||
Albert Pretorius <[email protected]> | ||
Alex Steele <[email protected]> | ||
Andriy Berestovskyy <[email protected]> | ||
Arne Beer <[email protected]> | ||
Carto | ||
Christopher Seymour <[email protected]> | ||
Daniel Harvey <[email protected]> | ||
David Coeurjolly <[email protected]> | ||
Deniz Evrenci <[email protected]> | ||
Dirac Research | ||
Dominik Czarnota <[email protected]> | ||
Eric Fiselier <[email protected]> | ||
Eugene Zhuk <[email protected]> | ||
Evgeny Safronov <[email protected]> | ||
Federico Ficarelli <[email protected]> | ||
Felix Homann <[email protected]> | ||
Google Inc. | ||
International Business Machines Corporation | ||
|
@@ -34,6 +39,7 @@ Maxim Vafin <[email protected]> | |
MongoDB Inc. | ||
Nick Hutchinson <[email protected]> | ||
Oleksandr Sochka <[email protected]> | ||
Ori Livneh <[email protected]> | ||
Paul Redmond <[email protected]> | ||
Radoslav Yovchev <[email protected]> | ||
Roman Lebedev <[email protected]> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change here is to address what exactly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! These were intentional.
As the commit message says, these reflect the changes in gbenchmark's CMakeLists.txt.
I think they removed
-Wfloat-equal
because if you have-Wall
, you don't have to explicitly enable this warning. Either that or they really want to==
floats and know what they're doing.And
-Wno-deprecated-declarations
was added because they deprecated theCSVReporter
and they use-Werror
likeponyc
does so it becomes impossible to buildgbenchmark
without disabling the warning. See google/benchmark#608-Wno-invalid-offsetof
was moved to avoid mixing the-Wno-
with other flags. This could probably be removed but it was here from the beginning so I kept it.