Change workspace based on scroll events #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/pop-os/cosmic-applets/blob/master/cosmic-applet-workspaces/src/wayland.rs has scroll accumulation with a timer just like I was thinking of, so doing the same thing should work. Perhaps libcosmic could provide some kind of helper for that... |
Works, I'm not sure how many pixels to interpret as a change to the workspace, and perhaps it should accumulate multiple deltas with a timer. Assuming some lower level of the stack isn't doing that already. I only see `ScrollDelta::Pixels` events, not `Lines`, though maybe that's relevant with a different type of input device. The behavior would also be clearer with animation, though it doesn't seem to bad (#32). Fixes #34.
Not sure the perfect way to do this; the workspace applet is a little different. A helper of some kind should be added to libcosmic.
ids1024
force-pushed
the
workspace-scroll
branch
from
5ac70c1 to
497d887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works, I'm not sure how many pixels to interpret as a change to the workspace, and perhaps it should accumulate multiple deltas with a timer. Assuming some lower level of the stack isn't doing that already. I only see
ScrollDelta::Pixelsevents, notLines, though maybe that's relevant with a different type of input device.The behavior would also be clearer with animation, though it doesn't seem to bad
(#32).
Fixes #34.