Update FmtImage.to_html()

[jrycw]

Hello team,

I'd like to format the column by providing an HTTP/HTTPS URL to the path parameter in GT.fmt_image() like so:

import polars as pl
from great_tables import GT

df = pl.DataFrame({"logo": ["GT_logo.svg"]})
GT(df).fmt_image(
    "logo",
    path="https://raw.githubusercontent.com/posit-dev/great-tables/main/docs/assets/",
)

I was expecting this outcome:

However, I'm encountering a TypeError: sub() missing 1 required positional argument: 'string'.

It appears that the error originates from this line:

great-tables/great_tables/_formats.py

Line 3529 in 016c67f

norm_path = re.sub(r"/\s+$", self.path)

If I understand correctly, this line is intended to do two things: (1) remove trailing spaces, if any, and (2) remove the trailing /, if present. To fix this, the line could be updated as follows:

norm_path = re.sub(r"/\s*$", "", self.path)

This would:

• Pass all three required arguments to re.sub().
• Change the + modifier to * to allow for zero or more spaces.

That said, I believe using self.path.rstrip().removesuffix("/") as proposed in this PR is more straightforward and easier to understand.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.72%. Comparing base (016c67f) to head (8fa2fd4).
Report is 15 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
+ Coverage   86.68%   86.72%   +0.03%     
==========================================
  Files          42       42              
  Lines        4685     4684       -1     
==========================================
+ Hits         4061     4062       +1     
+ Misses        624      622       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[machow]

@rich-iannone do you mind taking a look? Especially on double checkingnorm_path's job there? Seems like a nice addition!

(may be useful for us to leave a note here on what would happen in the gt r package if someone used an http path)

[rich-iannone]

LGTM!