Enhance GT.fmt_image()
to support http/https schema in the columns
parameter
#520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs: #444, #451.
Currently,
GT.fmt_image()
supports formatting images from URLs by combining thecolumns
andpath
parameters, as shown below:This PR proposes an enhancement to allow image formatting using only the
columns
parameter, enabling the following code to execute without errors:This modification should benefit users who retrieve a list of URLs through a database query and store them as a column in the DataFrame. A possible scenario can be illustrated with the following pseudo-code:
Additionally, this change would make it more convenient for users who want to place images in locations other than the body using
vals.fmt_image()
. For example:I believe this improvement will enhance the user experience and better align with the documentation, which states that complete http/https URLs should be accepted. That said, I'm open to any suggestions or feedback!