-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add val_fmt_image()
to enable image rendering in various components
#451
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
+ Coverage 87.70% 87.84% +0.13%
==========================================
Files 42 42
Lines 4832 4838 +6
==========================================
+ Hits 4238 4250 +12
+ Misses 594 588 -6 ☔ View full report in Codecov by Sentry. |
This will be a great addition, thank you! If you can, could you add some basic tests for this function in a new |
Sure. Since we have actual SVG files in the project, I thought it might be a good idea to directly test |
This would be an amazing feature, when do you think it will be released? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sorry for taking awhile to get back to this PR. Just reviewed again, did some testing, and everything is really good here! |
Related to #418.
It seems that users are interested in rendering images across different components. To support this, I'd like to propose introducing a
val_fmt_image()
function. With this function, we can achieve more flexibility, such as:The idea is to wrap the output from
val_fmt_image()
in thehtml()
function.