Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use full html page in show() for correct utf-8 display #458

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

machow
Copy link
Collaborator

@machow machow commented Sep 23, 2024

This PR addresses #414 by producing a full html page when using .show() to open a browser window. Previously, we only produced the table fragment, which for some reason caused the browser (or server) to screw up the encoding.

(The full html includes <meta charset="utf-8"/> which makes the encoding explicit)

@machow machow requested a review from rich-iannone September 23, 2024 18:08
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.75%. Comparing base (bacda7e) to head (ef25d8f).
Report is 67 commits behind head on main.

Files with missing lines Patch % Lines
great_tables/_export.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   86.37%   86.75%   +0.38%     
==========================================
  Files          42       42              
  Lines        4683     4750      +67     
==========================================
+ Hits         4045     4121      +76     
+ Misses        638      629       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machow
Copy link
Collaborator Author

machow commented Sep 23, 2024

shoot -- I need to fix a bit of code in our old blog post :/

@github-actions github-actions bot temporarily deployed to pr-458 September 23, 2024 18:52 Destroyed
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@machow machow merged commit a954d94 into main Sep 24, 2024
20 of 24 checks passed
@rich-iannone rich-iannone deleted the fix-show-utf8 branch September 25, 2024 01:55
@rich-iannone rich-iannone mentioned this pull request Sep 25, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants