Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update superbowl example to align with the new version of Polars #460

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jrycw
Copy link
Collaborator

@jrycw jrycw commented Sep 24, 2024

I've noticed the CI is failing due to the superbowl example. This PR updates the example to be compatible with the latest version of Polars.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base (b14c8f2) to head (a5c533a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage   86.77%   86.77%           
=======================================
  Files          42       42           
  Lines        4749     4749           
=======================================
  Hits         4121     4121           
  Misses        628      628           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrycw
Copy link
Collaborator Author

jrycw commented Sep 24, 2024

@machow , I hadn’t noticed that you fixed this issue in #458. However, it seems there's still a deprecation warning:

/tmp/ipykernel_4495/1980599939.py:2: DeprecationWarning: The argument `columns` for `DataFrame.pivot` is deprecated. It has been renamed to `on`.
pl.DataFrame({"x": list(range(10))})

This is coming from the preview site.

@machow machow self-requested a review September 24, 2024 16:12
Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for catching the extra deprecated piece! Let's merge this, and then I'll take the commit out of the PR you mention

@rich-iannone rich-iannone merged commit fd3ac52 into posit-dev:main Sep 24, 2024
13 checks passed
@jrycw jrycw deleted the superbowl branch September 24, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants