Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix deprecation warning in the superbowl example #462

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jrycw
Copy link
Collaborator

@jrycw jrycw commented Sep 25, 2024

@machow , it seems that the deprecation warning is coming from the first code block in the index.qmd.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.74%. Comparing base (d7f862c) to head (e5526e1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   86.74%   86.74%           
=======================================
  Files          42       42           
  Lines        4746     4746           
=======================================
  Hits         4117     4117           
  Misses        629      629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machow machow self-requested a review September 25, 2024 15:32
Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for being so good with all the polars related stuff :)

@rich-iannone rich-iannone merged commit e773048 into posit-dev:main Sep 25, 2024
13 checks passed
@jrycw jrycw deleted the superbowl2 branch September 25, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants