Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redefinition of \FA #235

Closed
wants to merge 2 commits into from
Closed

Fix redefinition of \FA #235

wants to merge 2 commits into from

Conversation

OJFord
Copy link
Collaborator

@OJFord OJFord commented Oct 2, 2018

This commit fixes an issue when using recent fontspec versions.

Described in: https://tex.stackexchange.com/a/453198/73121

Closes #234.

This commit fixes an issue when using recent fontspec versions.

Described in: https://tex.stackexchange.com/a/453198/73121

Closes posquit0#234.
@OJFord
Copy link
Collaborator Author

OJFord commented Oct 3, 2018

Hm, seems to pass compilation, but break any use of fontawesome icons.

FloThinksPi added a commit to FloThinksPi-Forks/Awesome-CV that referenced this pull request Nov 11, 2018
Fixes Compilation Error when commenting out the \newfont: xdvipdfmx:fatal: pdf_ref_obj(): passed invalid object.
As well als the Compilation Error: LaTeX3 Error: Command '\FA' already defined!For immediate help type H <return>.

Fixes posquit0#221 by unsetting /FA before redefining it.

In Contrary to other Pull Reqests posquit0#233 posquit0#235 and posquit0#236 i found, fontawsome works with this change.
Tested with MikTex on Windows.
@ashwinvis ashwinvis mentioned this pull request Nov 25, 2018
@posquit0 posquit0 closed this Dec 21, 2018
@posquit0 posquit0 removed the invalid label Dec 21, 2018
@OJFord OJFord deleted the patch-1 branch April 29, 2019 18:08
tomboy-64 added a commit to tomboy-64/Awesome-CV that referenced this pull request Aug 5, 2020
jumper047 pushed a commit to jumper047/Awesome-CV that referenced this pull request Oct 29, 2021
Fixes Compilation Error when commenting out the \newfont: xdvipdfmx:fatal: pdf_ref_obj(): passed invalid object.
As well als the Compilation Error: LaTeX3 Error: Command '\FA' already defined!For immediate help type H <return>.

Fixes posquit0#221 by unsetting /FA before redefining it.

In Contrary to other Pull Reqests posquit0#233 posquit0#235 and posquit0#236 i found, fontawsome works with this change.
Tested with MikTex on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Command \FA already defined
4 participants