Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the fontspec error about \newfontfamily #236

Closed
wants to merge 1 commit into from
Closed

fix the fontspec error about \newfontfamily #236

wants to merge 1 commit into from

Conversation

jeongwhanchoi
Copy link

@jeongwhanchoi jeongwhanchoi commented Oct 9, 2018 •
edited
Loading

Fix the fontspec error below; replace to \newfontfamily{\FA}{FontAwesome.otf}

screen shot 2018-10-09 at 2 52 04 pm

When compiling in local Tex (not Overleaf), this extension should be specified like this commit.

@jeongwhanchoi jeongwhanchoi mentioned this pull request Oct 9, 2018
Closed
FloThinksPi added a commit to FloThinksPi-Forks/Awesome-CV that referenced this pull request Nov 11, 2018
@FloThinksPi
Fixes posquit0#221 "Error: Command '\FA' already defined!"
1064980 
Fixes Compilation Error when commenting out the \newfont: xdvipdfmx:fatal: pdf_ref_obj(): passed invalid object.
As well als the Compilation Error: LaTeX3 Error: Command '\FA' already defined!For immediate help type H <return>.

Fixes posquit0#221 by unsetting /FA before redefining it.

In Contrary to other Pull Reqests posquit0#233 posquit0#235 and posquit0#236 i found, fontawsome works with this change.
Tested with MikTex on Windows.
@FloThinksPi FloThinksPi mentioned this pull request Nov 11, 2018
Closed
thehamstermuffin
thehamstermuffin reviewed Sep 26, 2019
View reviewed changes
fontawesome.sty
@@ -9,7 +9,7 @@
\usepackage{fontspec}

% Define shortcut to load the Font Awesome font.
\newfontfamily{\FA}{FontAwesome}
\newfontfamily{\FA}{FontAwesome.otf}
Copy link

@thehamstermuffin thehamstermuffin Sep 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work, but I think this should be ttf to correspond to the font file

Suggested change
\newfontfamily{\FA}{FontAwesome.otf}
\newfontfamily{\FA}{FontAwesome.ttf}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't otf format have more features than ttf? Having that in mind, otf would be the best choice if we add the corresponding file

mbaralle
mbaralle suggested changes Sep 27, 2019
View reviewed changes
fontawesome.sty
@@ -9,7 +9,7 @@
\usepackage{fontspec}

% Define shortcut to load the Font Awesome font.
\newfontfamily{\FA}{FontAwesome}
\newfontfamily{\FA}{FontAwesome.otf}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't otf format have more features than ttf? Having that in mind, otf would be the best choice if we add the corresponding file

thiagobfiorenza
thiagobfiorenza approved these changes Oct 3, 2019
View reviewed changes
Copy link

@thiagobfiorenza thiagobfiorenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right!

@crouther
Copy link

if this problem is resolved should the request be close?

@nikhil-bhat nikhil-bhat mentioned this pull request Jan 10, 2021
Merged
jumper047 pushed a commit to jumper047/Awesome-CV that referenced this pull request Oct 29, 2021
@FloThinksPi @jumper047
Fixes posquit0#221 "Error: Command '\FA' already defined!"
b034dbd 
Fixes Compilation Error when commenting out the \newfont: xdvipdfmx:fatal: pdf_ref_obj(): passed invalid object.
As well als the Compilation Error: LaTeX3 Error: Command '\FA' already defined!For immediate help type H <return>.

Fixes posquit0#221 by unsetting /FA before redefining it.

In Contrary to other Pull Reqests posquit0#233 posquit0#235 and posquit0#236 i found, fontawsome works with this change.
Tested with MikTex on Windows.
@OJFord
Copy link
Collaborator

OJFord commented Nov 10, 2021

Thank you - I think many of us have made this or similar fixes over the years as posquit0's had other priorities. I have push access now to help maintain Awesome-CV; so I went with my old PR for this (#235/#344) for no reason other than my own familiarity, that I know it's been working for me.

Please do ping me/open another PR if something's still not right or I missed something though! Cheers.

@OJFord OJFord closed this Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehamstermuffin thehamstermuffin thehamstermuffin approved these changes

@mbaralle mbaralle mbaralle requested changes

@thiagobfiorenza thiagobfiorenza thiagobfiorenza approved these changes

@luminousbeam luminousbeam luminousbeam approved these changes

@saihaj saihaj saihaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jeongwhanchoi @crouther @OJFord @thiagobfiorenza @luminousbeam @thehamstermuffin @mbaralle @saihaj