Fixes to enable xarray interfacing #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s xarray interface, while NcDatasetLike emulates nc4 mask+scale to support Iris.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally fixes problems with masked data.
The netcdf interface now presents 'raw' variable data in the ncdata objects, since xarray accesses nc4 files that way.
Meanwhile, to suit the Iris interface, the mask+scale operations are now implemented in the
NcVariable._data_arrayproperty interface, because Iris accesses nc4 that way.Also added specific purpose-built dataset testcases for
Meanwhile, the whole iris <-> xarray roundtrip tests idea seems to need a review.
iris-xr-iris is more-or-less feasible, but xr-iris-xr introduces so many problems, I have disabled all of that for now.