New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve lazy nature of Nc4DatasetLike variable data #39

Merged

pp-mo merged 1 commit into main from dslike_lazyfix

Jan 14, 2024

Owner

pp-mo commented Jan 4, 2024 •

edited

Loading

Also confirm in example code.
This was basically a bug introduced in #32 -- because np.ma.masked_equal does not vector to da.ma.masked_equal.

TODO:

~~add a proper unit test to ensure this works lazy-preserving~~
UPDATE will do this within forthcoming extra tests for ncdata.iris


          Preserve lazy nature of Nc4DatasetLike variable data, confirm in exam…

176fa7a

…ple code.

pp-mo force-pushed the dslike_lazyfix branch from 9b69316 to 176fa7a Compare

January 14, 2024 10:39

pp-mo marked this pull request as ready for review

January 14, 2024 10:39

pp-mo merged commit 59b9109 into main

3 checks passed

pp-mo deleted the dslike_lazyfix branch

January 14, 2024 10:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet