Skip to content

Commit

Permalink
Fixup Ban org.ow2.asm:asm in non-deployment modules quarkiverse#493
Browse files Browse the repository at this point in the history
  • Loading branch information
@ppalaga
ppalaga committed Aug 24, 2022
1 parent 75e49a2 commit 730b706
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 54 deletions.
84 changes: 36 additions & 48 deletions extensions/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,52 +21,40 @@
<module>transports-http-hc5</module>
</modules>

<build>
<plugins>
<plugin>
<groupId>org.codehaus.gmaven</groupId>
<artifactId>groovy-maven-plugin</artifactId>
<executions>
<execution>
<id>set-enforce-non-deployment-property</id>
<inherited>false</inherited>
<goals>
<goal>execute</goal>
</goals>
<phase>process-resources</phase>
<configuration>
<source>
if (project.artifactId.endsWith('-deployment')) {
properties['enforce-non-deployment.skip'] = true;
}
</source>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<executions>
<execution>
<id>enforce-non-deployment</id>
<configuration>
<skip>${enforce-non-deployment.skip}</skip>
<rules>
<bannedDependencies>
<excludes>
<!-- <exclude>org.ow2.asm:asm</exclude> -->
</excludes>
</bannedDependencies>
</rules>
</configuration>
<goals>
<goal>enforce</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>

<profiles>
<profile>
<id>non-deployment-bans</id>
<activation>
<file>
<exists>${project.basedir}/src/main/resources/META-INF/quarkus-extension.yaml</exists>
</file>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<executions>
<execution>
<id>enforce-non-deployment</id>
<configuration>
<skip>${enforce-non-deployment.skip}</skip>
<rules>
<bannedDependencies>
<excludes>
<exclude>org.ow2.asm:asm</exclude>
</excludes>
</bannedDependencies>
</rules>
</configuration>
<goals>
<goal>enforce</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>
6 changes: 0 additions & 6 deletions pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
<supported-maven.versions>[3.6.2,)</supported-maven.versions>

<cq-maven-plugin.version>3.1.1</cq-maven-plugin.version>
<groovy-maven-plugin.version>2.1.1</groovy-maven-plugin.version>
<maven-enforcer-plugin.version>3.0.0-M3</maven-enforcer-plugin.version>
<maven-eclipse-plugin.version>2.10</maven-eclipse-plugin.version>
<maven-idea-plugin.version>2.2.1</maven-idea-plugin.version>
Expand Down Expand Up @@ -138,11 +137,6 @@
<artifactId>maven-failsafe-plugin</artifactId>
<version>${maven-failsafe-plugin.version}</version>
</plugin>
<plugin>
<groupId>org.codehaus.gmaven</groupId>
<artifactId>groovy-maven-plugin</artifactId>
<version>${groovy-maven-plugin.version}</version>
</plugin>
<plugin>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-extension-maven-plugin</artifactId>
Expand Down

0 comments on commit 730b706

Please sign in to comment.