Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban org.ow2.asm:asm in non-deployment modules #493

Closed
ppalaga opened this issue Aug 16, 2022 · 2 comments · Fixed by #508 or #513
Closed

Ban org.ow2.asm:asm in non-deployment modules #493

ppalaga opened this issue Aug 16, 2022 · 2 comments · Fixed by #508 or #513
Milestone

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Aug 16, 2022

Before #487, we were banning org.ow2.asm:asm in some modules. We should investigate whether we should/can ban it after #487 and why.

When banned, it would have to be excluded from the follwing BOM entries:

[ERROR]     io.quarkiverse.cxf:quarkus-cxf:1.5.0-SNAPSHOT:jar pulls banned dependencies [org.ow2.asm:asm]
[ERROR]     io.quarkiverse.cxf:quarkus-cxf-rt-features-logging:1.5.0-SNAPSHOT:jar pulls banned dependencies [org.ow2.asm:asm]
[ERROR]     io.quarkiverse.cxf:quarkus-cxf-rt-features-metrics:1.5.0-SNAPSHOT:jar pulls banned dependencies [org.ow2.asm:asm]
[ERROR]     io.quarkiverse.cxf:quarkus-cxf-rt-transports-http-hc5:1.5.0-SNAPSHOT:jar pulls banned dependencies [org.ow2.asm:asm]
[ERROR]     org.apache.cxf:cxf-rt-ws-security:3.5.3:jar pulls banned dependencies [org.ow2.asm:asm]
[ERROR]     org.apache.cxf:cxf-rt-ws-mex:3.5.3:jar pulls banned dependencies [org.ow2.asm:asm]
[ERROR]     io.quarkiverse.cxf:quarkus-cxf-rt-ws-security:1.5.0-SNAPSHOT:jar pulls banned dependencies [org.ow2.asm:asm]

As a first step, we can do the above exclusions and check whether some tests fail.

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 17, 2022

Citing @famod from #487 (comment) :

It was excluded due to #226 (and banned in a later PR).

The runtime part of quarkus-cxf should not depend on asm.

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 22, 2022

The runtime part of quarkus-cxf should not depend on asm.

Hm... now I see. quarkus-core-deployment pulls asm via gizmo. So banning asm for both runtime and deployment artifacts is not possible. I'll try to do it for runtime modules at least.

@ppalaga ppalaga changed the title Figure out whether we need to ban org.ow2.asm:asm Ban org.ow2.asm:asm in non-deployment modules Aug 23, 2022
ppalaga added a commit to ppalaga/quarkus-cxf that referenced this issue Aug 23, 2022
ppalaga added a commit to ppalaga/quarkus-cxf that referenced this issue Aug 23, 2022
ppalaga added a commit to ppalaga/quarkus-cxf that referenced this issue Aug 23, 2022
ppalaga added a commit to ppalaga/quarkus-cxf that referenced this issue Aug 24, 2022
ppalaga added a commit to ppalaga/quarkus-cxf that referenced this issue Aug 24, 2022
@ppalaga ppalaga added this to the 1.5.0 milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant