FZF support #211

ddcien · 2018-12-13T09:16:55Z

FZF support has been integrated into my commits. Now you can handle location, symbol, and code action selections with FZF if it is loaded.

1. Implement lsp#ui#vim#workspace_executecommand; 2. Use FZF for choosing action; 3. Fix parse_range; 4. Implement universal codeAction handler; 5. Implement cquery codeAction handler;

mkwork · 2018-12-13T10:01:10Z

Sounds quite cool!

* Add <plug> mappings * Update doc

* Save/restore cursor position * Cosmetic change * selection should be inclusive Because exclusive doesn't select fisrt character with 1GvG0 * Remove last extra \n * Be graceful * Use winsaveview/winrestoreview

mattn · 2018-12-20T06:54:47Z

autoload/lsp/ui/vim.vim

+        let l:qfl = getqflist()
+        call map(l:qfl, {idx, item -> string(idx + 1) . '. ' . fnamemodify(expand(bufname(item['bufnr'])), ":~:.") . ':' . string(item['lnum']) . ':' . string(item['col']) . ':' . item['text']})
+        call fzf#run(fzf#wrap({'source': l:qfl, 'sink': function('s:jump_to_location'), 'options': '--reverse +m --prompt="Jump> "'}))
+    endif


Please reverse the condition. We may add yet-another selector in future.

if extensibie1 call do_extend1() return endif if extensibie2 call do_extend2() return endif call do_original()

Yes, that makes sense. Fixed.

Convert col to virtcol in `parse_range`

prabirshrestha

Thanks for this great PR. Looking forward to it. Would it be possible to break the PR into multiple smaller PRs that can be merged separately?

As for FZF I'm a bit hesitant without full configuration and would like it to be in a different repo because lot of people have their own favorite fuzzy ui and would like to avoid maintaining all possible ui support in this repo. Might be something like lsp#ui#register_quickpick_ui('fzf', s:fuzzy_ui)that others can call and the user can set the default let g:lsp_default_fuzzy_ui = 'fzf'. This would allow anyone to build something like vim-lsp-ui-fzf.vim, vim-lsp-ui-ctrlp.vim, vim-lsp-ui-vim-fz.vim, vim-lsp-ui-denite.vim as external repos. I'm more than happy to officially endorse it in README.md. The primary reason I'm not fan of any fuzzy ui in vim is because they don't support 'on_change' callback when searching which is very useful when searching workspace symbols and other big searches.

prabirshrestha · 2018-12-21T05:11:57Z

autoload/lsp.vim

@@ -135,7 +137,7 @@ function! s:register_events() abort
        autocmd BufReadPost * call s:on_text_document_did_open()
        autocmd BufWritePost * call s:on_text_document_did_save()
        autocmd BufWinLeave * call s:on_text_document_did_close()
-        autocmd InsertLeave * call s:on_text_document_did_change()
+        autocmd InsertLeave,TextChanged * call s:on_text_document_did_change()


would need to debounce TextChanged as it could slow down vim due to did change. When we implement incremental change it would be easier. But there is a PR currently for it at #188

prabirshrestha · 2018-12-21T05:24:24Z

autoload/lsp/ui/vim.vim

        return
    endif

-    while l:index < len(l:codeActions)
-        call add(l:choices, string(l:index + 1) . ' - ' . l:codeActions[index]['title'])
+    if a:action['command'] ==# 'cquery._applyFixIt'


:( we shouldn't add lang server specific things here. Why is this needed?

prabirshrestha · 2018-12-21T05:32:40Z

autoload/lsp/ui/vim/utils.vim

@@ -54,6 +55,14 @@ let s:symbol_kinds = {
    \ '16': 'number',
    \ '17': 'boolean',
    \ '18': 'array',
+    \ '19': 'object',


this can be in a different PR.

prabirshrestha · 2018-12-21T11:02:21Z

I'm getting closer to implementing a new fuzzy search plugin in vim with on_change support. The api will look something like this. (I haven't pushed the code yet)

function! s:on_change(id, value) abort
    " todo: properly debounce and cancel previous on-going search
    call s:search_npm(a:value, {items->quickpick#set_items(a:id, items)})
endfunction

function! s:on_accept(id, items) abort
    " use jobs for async install
    call quickpick#close(a:id)
    call job_start([&shell, &shellcmdflag, 'npm install ' . a:items[0]])
endfunction

let id = quickpick#create({
    \ 'on_change': function('s:on_change'),
    \ 'on_accept': function('s:on_accept'),
    \ 'auto_open': 0
    \ })
call quickpick#show(id)

Simple pickers one can directly using this api.

call quickpick#create({
    \ 'on_accept': function('s:on_accept'),
    \ 'items': ['item1', 'item2'],
    \ })

Then we can expose a extension point in vim-lsp that will look something like this.

call lsp#register_quickpick_ui('quickpick.vim', function('s:quickpick_vim'))
call lsp#register_quickpick_ui('ctrlp', function('s:ctrlp_quickpick'))
call lsp#register_quickpick_ui('fzf', function('s:fzf_quickpick'))
let g:lsp_default_quickpick_ui = 'fzf'

We need to figure out what the interface for register_quickpick_ui would like.

prabirshrestha · 2018-12-23T21:27:15Z

I have pushed the code for quickpick.vim. It is at a very early stage. In the meantime you can refer to prabirshrestha/quickpick.vim#1 for roadmap. I wouldn;'t support quickpick yet in vim-lsp because it is still very much work in progress and the api's may change.

prabirshrestha · 2018-12-30T20:54:36Z

Finally got a proof of concept for quickpick. Here is how it looks. This makes it lot more powerful than FZF/Ctrlp and would work well for document and specially workspace symbols where a project could have possible thousands of symbols and you would want the langserver to search instead of vim-lsp. quickpick.vim just acts as a dump ui.

All the above is implemented in pure vimscript and follows the footstep of vim-lsp and asyncomplete.vim

Note: quickpick.vim is very much work in progress https://github.com/prabirshrestha/quickpick.vim

mattn · 2019-02-15T08:58:50Z

Hi @ddcien

Thanks your contribution. Will you work about this PR ? If you don't, I'll continue to implement codeAction with your commits.

edganiukov · 2019-03-18T11:56:56Z

I would love to have FZF support.

mattn · 2019-03-19T00:01:48Z

IMO, I do not like to lock-in to 1 selector command.

prabirshrestha · 2019-06-15T17:54:33Z

No plans to support FZF as first class support. There are lot of fuzzy search UI and I would like to avoid supporting N number of UIs. I personally use ctrlp and vim-fz with fzf executable which I find it lot better than fzf.vim.

if executable('fzf')
  nmap ,f <Plug>(fz)
  let g:fz_command = 'fzf'
  let g:fz_command_files = ''
  let g:fz_command_options_action = '--expect=%s'
  let g:ctrlp_map = ''
  nnoremap <C-p> :call fz#run({ 'type': 'cmd', 'cmd': 'git ls-files' })<CR>
else

Feel free to send a PR support for extending vim-lsp something like this.

call lsp#register_list_ui(myfzflistui#options())
let g:lsp_list_ui = ['fzf', 'quickfix', 'loclist']`

mkwork · 2019-06-16T00:08:49Z

Fuzzy is not particular solution. That's algorithm.

jiz4oh · 2023-08-16T03:18:41Z

Hi everyone, I have created a plugin vim-lspfuzzy that can show etc. documentsymbol and references in fzf window, any suggestion is appreciated and pr welcome

QifengLu added 4 commits December 13, 2018 13:04

Use FZF for handling locations

b123393

Add command provider checker

85d38ca

Add lsp#ui#vim#workspace_executecommand

66d0a4f

Fix codeAction problems

1852ea8

1. Implement lsp#ui#vim#workspace_executecommand; 2. Use FZF for choosing action; 3. Fix parse_range; 4. Implement universal codeAction handler; 5. Implement cquery codeAction handler;

QifengLu added 3 commits December 13, 2018 18:57

FixIt automatically

badce69

Fix the rename bug

7d48c9c

Filter out duplicated locations, symbols and diagnostics

1600b41

ddcien force-pushed the master branch from 40f8497 to 1600b41 Compare December 17, 2018 01:56

mattn and others added 10 commits December 18, 2018 09:42

Add <plug> mappings (prabirshrestha#210)

8e24336

* Add <plug> mappings * Update doc

Format (prabirshrestha#209)

bbbbc53

* Save/restore cursor position * Cosmetic change * selection should be inclusive Because exclusive doesn't select fisrt character with 1GvG0 * Remove last extra \n * Be graceful * Use winsaveview/winrestoreview

Simplify apply_text_edits

881950b

Sort location list

62194da

Add option g:lsp_sort_locations

7155426

Support 'textDocument/documentHighlight'

de99856

Complete symbol_kinds

435b553

Support 'textDocument/signatureHelp'

09d5a64

Support 'documentLink' and 'CodeLens'

e17163f

Fix lsp#get_position

d1840fd

mattn reviewed Dec 20, 2018

View reviewed changes

QifengLu added 4 commits December 20, 2018 17:19

Handle codeLens and documentLink

dcd3f45

Auto update codeLens

d8195cd

Fix apply_text_edits

f37b97f

Convert col to virtcol in `parse_range`

Reverse the condition

05753a1

prabirshrestha changed the title ~~FZF supoorted~~ FZF support Dec 21, 2018

prabirshrestha requested changes Dec 21, 2018

View reviewed changes

mattn added the waiting for reply label Dec 28, 2018

hrsh7th mentioned this pull request Jan 8, 2019

Add lsp_location_update autocmd #234

Closed

mattn added the enhancement label Jan 29, 2019

prabirshrestha mentioned this pull request Feb 15, 2019

[WIP] implement executeCommand #303

Closed

prabirshrestha removed the waiting for reply label Jun 15, 2019

prabirshrestha closed this Jun 15, 2019

prabirshrestha mentioned this pull request Nov 27, 2019

Support custom selector for LspCodeAction #581

Closed

This was referenced Aug 16, 2020

Support custom commands to open QuickFix windows #883

Closed

ALE compatibility #882

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FZF support #211

FZF support #211

ddcien commented Dec 13, 2018

mkwork commented Dec 13, 2018

mattn Dec 20, 2018

ddcien Dec 21, 2018

prabirshrestha left a comment

prabirshrestha Dec 21, 2018

prabirshrestha Dec 21, 2018

prabirshrestha Dec 21, 2018

prabirshrestha commented Dec 21, 2018

prabirshrestha commented Dec 23, 2018

prabirshrestha commented Dec 30, 2018

mattn commented Feb 15, 2019

edganiukov commented Mar 18, 2019

mattn commented Mar 19, 2019

prabirshrestha commented Jun 15, 2019

mkwork commented Jun 16, 2019

jiz4oh commented Aug 16, 2023

FZF support #211

FZF support #211

Conversation

ddcien commented Dec 13, 2018

mkwork commented Dec 13, 2018

mattn Dec 20, 2018

Choose a reason for hiding this comment

ddcien Dec 21, 2018

Choose a reason for hiding this comment

prabirshrestha left a comment

Choose a reason for hiding this comment

prabirshrestha Dec 21, 2018

Choose a reason for hiding this comment

prabirshrestha Dec 21, 2018

Choose a reason for hiding this comment

prabirshrestha Dec 21, 2018

Choose a reason for hiding this comment

prabirshrestha commented Dec 21, 2018

prabirshrestha commented Dec 23, 2018

prabirshrestha commented Dec 30, 2018

mattn commented Feb 15, 2019

edganiukov commented Mar 18, 2019

mattn commented Mar 19, 2019

prabirshrestha commented Jun 15, 2019

mkwork commented Jun 16, 2019

jiz4oh commented Aug 16, 2023