Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom selector for LspCodeAction #581

Closed
wants to merge 2 commits into from
Closed

Support custom selector for LspCodeAction #581

wants to merge 2 commits into from

Conversation

kyoh86
Copy link

@kyoh86 kyoh86 commented Nov 27, 2019

I want to use fzf.vim instead of default vim function inputlist.

@prabirshrestha
Copy link
Owner

Some of my previous thoughts can be found here. #211 (comment) Basic idea is that it needs to be extendable and there should be no code related to fzf in vim-lsp repo similar to how we implemented snippets support.

There are lot of ui selectors and we should be able to easily use any of those.

@kyoh86
Copy link
Author

kyoh86 commented Nov 28, 2019

@prabirshrestha thank you for your reply.

I thought so too.
So this PR will provide just custom option g:lsp_code_action_selector.
There's no code related to fzf in vim-lsp (but only samples on doc).

@kyoh86
Copy link
Author

kyoh86 commented Dec 1, 2019

But I understood your idea.
I'm going to wait that you implement your idea...

@kyoh86 kyoh86 closed this Dec 1, 2019
@kyoh86 kyoh86 deleted the custom-selector branch December 13, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants