ci: Attempting to fix Yarn 2 PNP test

[rschristian]

What kind of change does this PR introduce?

CI fix

Did you add tests for your changes?

Existing cover this

Summary

yarnpkg/berry#2935

Honestly Yarn 2 seems to be so broken in the ecosystem at large & unused I don't think it's worth the time testing against.

Does this PR introduce a breaking change?

No

[changeset-bot]

⚠️ No Changeset found

Latest commit: e812034

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[merceyz]

Honestly Yarn 2 seems to be so broken in the ecosystem at large & unused I don't think it's worth the time testing against.

Ouch, sorry this issue made you come to that conclusion.

To give some context on what's going on here:
TypeScript has it's own resolution algorithm so patching require.resolve, which is usually enough for most tools, wasn't enough to give it PnP support. We opened microsoft/TypeScript#35206 but progress on getting it merged was too slow for us so we resorted to applying the PR as a patch automatically when installing TypeScript, sadly the patch doesn't apply cleanly to all versions of TypeScript so we need to update it every now and then which is what happened here yarnpkg/berry#2889.

EDIT:
I added an e2e test to our repo as well but by the time it catches issues it will be too late - yarnpkg/berry#2958

[rschristian]

Oh it's most certainly not just this issue, but the myriad of issues/discussions that have been raised (and raised again and again) about Yarn's future.

I'm not against merging in any PR's that help compat like your own #1418, or even having code that does nothing but support Yarn 2, but I do disagree with spending any time ensuring compat ourselves. It's just not an effective use of time for a niche tool which breaks compat with a ton of the ecosystem.

[merceyz]

We've fixed it on our side so this can be closed as the next CI run will pick up the fix on its own