feat(cli): add monorepo and Yarn PnP support

[merceyz]

What kind of change does this PR introduce?

bugfix, feature

Did you add tests for your changes?

Added an e2e test that will test preact-cli for undeclared dependencies and incorrect assumptions about the node_modules layout using Yarn PnP's strict dependency checks.

Summary

preact-cli doesn't work with Yarn PnP and monorepos using node_modules due to its incorrect assumptions about the node_modules layout, various undeclared dependencies, and not resolving dependencies it provides.

Fixes #1046
Fixes #1105
Fixes #1043

Does this PR introduce a breaking change?
No

Other information

N/A

[changeset-bot]

🦋 Changeset detected

Latest commit: d9df4d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
preact-cli	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[prateekbh]

This is awesome. Thanks @merceyz .
Can you add a test case where one of the pages uses any hook? Thats where i guess this broke earlierr

[merceyz]

Can you add a test case where one of the pages uses any hook? Thats where i guess this broke earlierr

In normal repos the behaviour should be the same, and hopefully already covered by tests

[merceyz]

When run in a monorepo where the hoisting is good this folder wont exist so checking if the project is installed like this is not correct

[ljharb]

Note that adding peer deps is a breaking change, even when optional, for clients that don’t support optional peer deps - which includes most of npm 6, and some versions of yarn.

[merceyz]

Note that adding peer deps is a breaking change, even when optional, for clients that don’t support optional peer deps - which includes most of npm 6, and some versions of yarn.

@ljharb To prevent old package managers from freaking out while letting newer package mangers know about them Yarn and pnpm (unsure about npm) supports just setting peerDependenciesMeta.optional, so the entries in peerDependencies can be removed if that's what the Preact team wants

[ljharb]

@merceyz yes, i'm saying that support for peerDependenciesMeta itself isn't in older versions of yarn, pnpm, or npm, which makes it a breaking change, because prior to peerDependenciesMeta.optional, all peer deps are and have always been required.

You can mitigate this by adding engines entries for yarn and npm (and pnpm, i suppose) - but doing so is also a breaking change.

[merceyz]

@merceyz yes, i'm saying that support for peerDependenciesMeta itself isn't in older versions of yarn, pnpm, or npm, which makes it a breaking change, because prior to peerDependenciesMeta.optional, all peer deps are and have always been required.

I know, that's why I said only specifying that field is the solution to that problem

[...] just setting peerDependenciesMeta.optional, so the entries in peerDependencies can be removed if that's what the Preact team wants

[ljharb]

I’m under the impression that peer deps are invalid if they are only listed in peerDependenciesMeta - Meta is a modifier, not a declaration.

[merceyz]

Yarn and pnpm (again, unsure about npm) treats them as an implicit peer dependency to allow projects to declare their dependencies without messing with older package managers

[osdiab]

I can really use this at the moment - any idea when the next preact-cli release to npm might be released? thanks!

[rschristian]

This breaks the getLoadersByName helper as loaders will now have their full path in the file system as the name.