Using same version of preact for pre-rendering #803
Conversation
|
Maybe we should add a note on that somewhere in the FAQ maybe? or Readme? |
|
about the comments i added? |
|
Well..... For users. I think users will expect the user-land preact to affect pre-rendering Preact. |
|
@hassanbazzi I updated the PR to use modules from user land instead its just that it has an added step of installing |
|
Not entirely sure how to write a test for it |
This reverts commit 8f8f655.
|
:| this was breaking the current tests.... |
|
I already have it |
|
|
||
| let preact = require('preact'), | ||
| renderToString = require('preact-render-to-string'); | ||
| const preact = require(require.resolve(`${cwd}/node_modules/preact`)); |
There was a problem hiding this comment.
Currently, using a monorepo manager like lerna this workaround breaks the build process and returns:
✖ ERROR Template execution failed: Error: Cannot find module './node_modules/preact'
The cwd is located inside root/packages/mypack and is looking for a root/packages/mypack/node_modules, which however is located in root/node_modules. Node won't resolve correctly due to lernas or yarns module mgmt and thus this will break.
I reverted the changes and logged destination. A revert worked but I think changing the destination to: ${__dirname}/../../../../preact and ${__dirname}/../../../../preact-render-to-string would work too.
Not sure what's more elegant...
There was a problem hiding this comment.
is there any workaround for this? I just moved a preact app into my monorepo to not have to maintain it in a separate repo, and I'm running into this exact error.
There was a problem hiding this comment.
@alexjsdev With Lerna and Yarn workspaces no. If you disable yarn workspaces this should work with Lerna though.
Fixes #795
What kind of change does this PR introduce?
Fixes duplicate preact problem.
preact. andpreact-render-to-stringfrom user land.preact-render-to-stringto local copy but wont work with preact-Xpreact-render-to-stringin all our template'spackage.jsonDid you add tests for your changes?
Already exist
Does this PR introduce a breaking change?
No