Skip to content

Commit

Permalink
MicroAd: Use HTTPS in all requests (#4220)
Browse files Browse the repository at this point in the history
* Always use HTTPS endpoint in MicroAd

* Update code

* Fixed a broken test in MicroAd
  • Loading branch information
strong-zero authored and mkendall07 committed Sep 30, 2019
1 parent 21f1275 commit 3ed4ba2
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion modules/microadBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { BANNER } from '../src/mediaTypes';
const BIDDER_CODE = 'microad';

const ENDPOINT_URLS = {
'production': '//s-rtb-pb.send.microad.jp/prebid',
'production': 'https://s-rtb-pb.send.microad.jp/prebid',
'test': 'https://rtbtest.send.microad.jp/prebid'
};
export let ENVIRONMENT = 'production';
Expand Down
7 changes: 7 additions & 0 deletions test/spec/modules/microadBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,13 @@ describe('microadBidAdapter', () => {
);
});
});

it('should always use the HTTPS endpoint https://s-rtb-pb.send.microad.jp/prebid even if it is served via HTTP', () => {
const requests = spec.buildRequests([bidRequestTemplate], bidderRequest);
requests.forEach(request => {
expect(request.url.lastIndexOf('https', 0) === 0).to.be.true;
});
});
});

describe('interpretResponse', () => {
Expand Down

0 comments on commit 3ed4ba2

Please sign in to comment.