Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MicroAd: Use HTTPS in all requests #4220

Merged
merged 3 commits into from
Sep 30, 2019
Merged

MicroAd: Use HTTPS in all requests #4220

merged 3 commits into from
Sep 30, 2019

Conversation

strong-zero
Copy link
Contributor

Type of change

  • Feature
  • Other

Description of change

  • Stop using the protocol-relative URL of the MicroAd prebid endpoint.

Other information

  • This PR will be followed by enabling secure cookies in the MicroAd prebid endpoint.

mkendall07
mkendall07 approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkendall07
Copy link
Member

@strong-zero
Change looks good but the test is failing:

 microadBidAdapter
    buildRequests
      ✗ should always use the HTTPS endpoint https://s-rtb-pb.send.microad.jp/prebid even if it is served via HTTP
	TypeError: Object doesn't support property or method 'startsWith'
	   at Anonymous function (webpack:///test/spec/modules/microadBidAdapter_spec.js:265:8 <- test/test_index.js:160380:9)
	   at Anonymous function (webpack:///test/spec/modules/microadBidAdapter_spec.js:264:6 <- test/test_index.js:160379:7)

@mkendall07 mkendall07 self-assigned this Sep 23, 2019
@strong-zero
Copy link
Contributor Author

OK. I'll fix it up 😢

@mkendall07 mkendall07 merged commit 3ed4ba2 into prebid:master Sep 30, 2019
@strong-zero strong-zero deleted the use-https-in-microad branch October 3, 2019 10:28
@pm-manasi-moghe pm-manasi-moghe mentioned this pull request Jan 13, 2021
Merged
10 tasks
@pm-manasi-moghe pm-manasi-moghe mentioned this pull request Jan 25, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkendall07 mkendall07 mkendall07 approved these changes

Assignees

@mkendall07 mkendall07

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strong-zero @mkendall07