Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrebidJS User Id module should share userIds in ORTB Eids format as well #4167

Closed
wants to merge 11 commits into from
Closed

PrebidJS User Id module should share userIds in ORTB Eids format as well #4167

wants to merge 11 commits into from

Conversation

pm-harshad-mane
Copy link
Contributor

Type of change

  • Feature

Description of change

For details please refer #4166

@pm-harshad-mane
userId_subModule ortbFormat function support
b12beec 
bid.userId the current userId object
bid.userIdEids will have userId in ORTB eids format
No unit test case are broken :)
@pm-harshad-mane
adding support for ortbFormat function
e8b9949
@pm-harshad-mane
adding support for ortbFormat function
6c530be
@pm-harshad-mane
Copy link
Contributor Author

Please note that this PR is not ready yet, I raised just to give reference in the issue #4166 and confirm the approach.

smenzer
smenzer reviewed Sep 6, 2019
View reviewed changes
modules/id5IdSystem.js Outdated Show resolved Hide resolved
smenzer
smenzer reviewed Sep 6, 2019
View reviewed changes
modules/id5IdSystem.js Outdated Show resolved Hide resolved
@jsnellbaker jsnellbaker requested a review from idettman September 9, 2019 16:54
@jsnellbaker
Copy link
Collaborator

Hi @pm-harshad-mane

Based on the earlier note, please confirm when this PR is ready for review. I have tagged @idettman to do the initial review once it's ready. Thanks!

@pm-harshad-mane
Copy link
Contributor Author

Hello @jsnellbaker ,
I still need to make a few changes, I will try to complete the code changes by end-of-week.

@idettman
Copy link
Contributor

Any updates on when this will be ready?

@bretg
Copy link
Collaborator

bretg commented Sep 30, 2019

@pm-harshad-mane - could you perhaps update the prebidServerBidAdapter to utilize these eids as well? Several of these user id modules are missing in the server-to-server scenario.

@idettman
Copy link
Contributor

Review is waiting on the prebid server adapter change bret requested to add the eid support

@idettman
Copy link
Contributor

Also, is the the "on hold" tag valid for this PR still?

@idettman idettman assigned pm-harshad-mane and unassigned idettman Dec 4, 2019
idettman
idettman suggested changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs update to resolve conflict

@harpere
Copy link
Collaborator

harpere commented Mar 5, 2020

@pm-harshad-mane anything going to happen with this? should we close it?

@pm-harshad-mane
Copy link
Contributor Author

Hello @hadarpeer ,
This has been done with #4916
We can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smenzer smenzer smenzer left review comments

@idettman idettman idettman requested changes

Assignees

@pm-harshad-mane pm-harshad-mane

Labels
needs update on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pm-harshad-mane @jsnellbaker @idettman @bretg @harpere @smenzer