-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UserId module will provide sub-module ids in ORTB eids format #4916
Conversation
Hi @jsnellbaker , |
I think for these new fields, they should be documented somehow on the userId module page on prebid.org. Could you put something together? Additionally, I understand these new fields are something that could be used by the PBS adapter. If these values are set up in an innate format that could be directly passed to the PBS ORTB request, could you make some updates to the current logic we have in the PBS adapter to pass the whole set of data as is? This would save us the trouble of individually populating every possible userId value in the ORTB request in the PBS adapter. Let me know your thoughts on the above (if it would be possible or no). Thanks. |
Thanks for the suggestion @jsnellbaker .
Can we take bidder changes in separate PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do those updates as a follow-up, I think that's fine. Thanks for putting together the docs PR as well.
Thanks @jsnellbaker! |
Thank you @idettman! |
…#4916) * added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * in-dev changes * indentation * adding unit test cases * added more unit test cases * attach ext only if it not null or undefined * unit test cases in userId module * unit test case for undefined ext value * added netid support with unit test cases
Type of change
Description of change
Many bidders are converting ids provided by UserId module into ORTB eids format.
With this PR, UserId module will provide sub-module ids in ORTB eids format as well.
Current:
validBidRequests[].userId
New:
validBidRequests[].userId and validBidRequests[].userIdAsEids