Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserId module will provide sub-module ids in ORTB eids format #4916

Merged
merged 36 commits into from
Mar 5, 2020

Conversation

pm-harshad-mane
Copy link
Contributor

Type of change

  • [ X ] Feature

Description of change

Many bidders are converting ids provided by UserId module into ORTB eids format.
With this PR, UserId module will provide sub-module ids in ORTB eids format as well.
Current: validBidRequests[].userId
New: validBidRequests[].userId and validBidRequests[].userIdAsEids

@pm-harshad-mane
Copy link
Contributor Author

Hi @jsnellbaker ,
After many attempts, CI has passed :-)
Could you please review the PR?

@jsnellbaker jsnellbaker self-assigned this Mar 3, 2020
@jsnellbaker
Copy link
Collaborator

Hi @pm-harshad-mane

I think for these new fields, they should be documented somehow on the userId module page on prebid.org. Could you put something together?

Additionally, I understand these new fields are something that could be used by the PBS adapter. If these values are set up in an innate format that could be directly passed to the PBS ORTB request, could you make some updates to the current logic we have in the PBS adapter to pass the whole set of data as is? This would save us the trouble of individually populating every possible userId value in the ORTB request in the PBS adapter.

Let me know your thoughts on the above (if it would be possible or no). Thanks.

@pm-harshad-mane
Copy link
Contributor Author

pm-harshad-mane commented Mar 3, 2020

Thanks for the suggestion @jsnellbaker .
The idea is to avoid code duplication in multiple bidders like PBS, PubMatic, etc.
I wanted to wait for the review before I update the bidders. PBS will just need to copy as following

ortbPayload.user.ext.eids = validBidRequests[0].userIdAsEids;

Can we take bidder changes in separate PR?
I will share a PR for documentation on prebid.org.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pm-harshad-mane

If we do those updates as a follow-up, I think that's fine. Thanks for putting together the docs PR as well.

@jsnellbaker jsnellbaker added needs 2nd review Core module updates require two approvals from the core team and removed needs docs labels Mar 4, 2020
@pm-harshad-mane
Copy link
Contributor Author

Thanks @jsnellbaker!

@idettman idettman merged commit fc770a3 into prebid:master Mar 5, 2020
@pm-harshad-mane
Copy link
Contributor Author

Thank you @idettman!

rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
…#4916)

* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* in-dev changes

* indentation

* adding unit test cases

* added more unit test cases

* attach ext only if it not null or undefined

* unit test cases in userId module

* unit test case for undefined ext value

* added netid support with unit test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants