Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicroAd: Use HTTPS in all requests #4220

Merged
merged 3 commits into from
Sep 30, 2019
Merged

MicroAd: Use HTTPS in all requests #4220

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b98b61
Always use HTTPS endpoint in MicroAd
Sep 22, 2019
bf9b68a
Update code
Sep 20, 2019
48c2d5a
Fixed a broken test in MicroAd
Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/microadBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { BANNER } from '../src/mediaTypes';
const BIDDER_CODE = 'microad';

const ENDPOINT_URLS = {
'production': '//s-rtb-pb.send.microad.jp/prebid',
'production': 'https://s-rtb-pb.send.microad.jp/prebid',
'test': 'https://rtbtest.send.microad.jp/prebid'
};
export let ENVIRONMENT = 'production';
Expand Down
7 changes: 7 additions & 0 deletions test/spec/modules/microadBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,13 @@ describe('microadBidAdapter', () => {
);
});
});

it('should always use the HTTPS endpoint https://s-rtb-pb.send.microad.jp/prebid even if it is served via HTTP', () => {
const requests = spec.buildRequests([bidRequestTemplate], bidderRequest);
requests.forEach(request => {
expect(request.url.startsWith('https')).to.be.true;
});
});
});

describe('interpretResponse', () => {
Expand Down