Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yieldmo prebid3.0 compliance, gdpr upadtes. remove openxoutstream bidder #4485

Merged
merged 41 commits into from
Dec 17, 2019
Merged

Yieldmo prebid3.0 compliance, gdpr upadtes. remove openxoutstream bidder #4485

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
889e5f0
update maintainer email
Feb 9, 2018
147c1a0
Merge remote-tracking branch 'upstream/master'
ym-elber Jul 29, 2019
8729d7c
Merge pull request #3 from yieldmo/upstream-sync
Jul 30, 2019
32c1c68
Merge branch 'master' of https://github.com/prebid/Prebid.js
Oct 15, 2019
4fd8634
add stringified schain
Oct 15, 2019
75d3036
Revert "add stringified schain"
Oct 15, 2019
4efef2a
pass along gdpr consent string and gdpr applies through get
Oct 16, 2019
05dbe64
use paramter gdprConsent
Oct 17, 2019
c4820cb
Merge pull request #5 from yieldmo/FS-7684-pass-consent-string
MelodyLi2017 Oct 18, 2019
49de31f
add stringified schain
Oct 15, 2019
3e384c9
don't change other files
Oct 15, 2019
5a71559
Merge pull request #4 from yieldmo/FS-7695-schain
MelodyLi2017 Oct 21, 2019
17108a4
change parameter namves
Oct 21, 2019
c1f47bf
Merge pull request #6 from yieldmo/change-param-names
MelodyLi2017 Oct 22, 2019
217eb0c
updates bidder module to be 3.0 compliant, and tests
HolzAndrew Oct 25, 2019
eeff0f4
Merge pull request #7 from yieldmo/FS-7762
HolzAndrew Oct 28, 2019
5854686
deletes openxoutstream adapter
HolzAndrew Nov 1, 2019
6b16a1f
fix broken yieldmo test
HolzAndrew Nov 1, 2019
8f3f98a
remove log
HolzAndrew Nov 1, 2019
5398c6d
Merge pull request #8 from yieldmo/FS-7766
Nov 12, 2019
c0cab3e
remove utils functions that will be depricated in 3.0 and use new ref…
HolzAndrew Nov 22, 2019
18ed64c
Merge pull request #9 from yieldmo/FS-7762-updates
HolzAndrew Nov 22, 2019
32bef9d
use prebids gettopwindow util functions. update markdown with 3.0 com…
HolzAndrew Nov 26, 2019
1ec3f23
Merge pull request #10 from yieldmo/FS-7762-updates
HolzAndrew Nov 26, 2019
e5af53a
Pass along us_privacy string
ym-elber Nov 26, 2019
7012a86
Merge pull request #11 from yieldmo/FS-7901-us-privacy
Nov 27, 2019
6dc4d82
add stringified schain
Oct 15, 2019
078dde0
Revert "add stringified schain"
Oct 15, 2019
76395db
pass along gdpr consent string and gdpr applies through get
Oct 16, 2019
c8f1bb6
use paramter gdprConsent
Oct 17, 2019
f44b9ba
add stringified schain
Oct 15, 2019
3c08912
don't change other files
Oct 15, 2019
2bd4486
change parameter namves
Oct 21, 2019
b05b9af
updates bidder module to be 3.0 compliant, and tests
HolzAndrew Oct 25, 2019
317b18f
deletes openxoutstream adapter
HolzAndrew Nov 1, 2019
493ea66
fix broken yieldmo test
HolzAndrew Nov 1, 2019
f66291a
remove log
HolzAndrew Nov 1, 2019
ba44122
remove utils functions that will be depricated in 3.0 and use new ref…
HolzAndrew Nov 22, 2019
e185504
use prebids gettopwindow util functions. update markdown with 3.0 com…
HolzAndrew Nov 26, 2019
0072141
Pass along us_privacy string
ym-elber Nov 26, 2019
11366c8
Merge pull request #13 from yieldmo/master-copy-2
HolzAndrew Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
213 changes: 0 additions & 213 deletions modules/openxoutstreamBidAdapter.js
View file
Open in desktop

This file was deleted.

43 changes: 0 additions & 43 deletions modules/openxoutstreamBidAdapter.md
View file
Open in desktop

This file was deleted.

14 changes: 11 additions & 3 deletions modules/yieldmoBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const spec = {
* @param {BidRequest[]} bidRequests A non-empty list of bid requests which should be sent to the Server.
* @return ServerRequest Info describing the request to the server.
*/
buildRequests: function(bidRequests) {
buildRequests: function(bidRequests, bidderRequest) {
let serverRequest = {
p: [],
page_url: utils.getTopWindowUrl(),
Copy link
Contributor

@Fawke Fawke Nov 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utils.getTopWindowUrl() function will be deprecated in prebid 3.0. More details about the deprecations here. Instead of using those deprecated functions, you can read the info from the bidRequest object. Find more details here.

Same thing applies to the utils.getTopWindowReferrer you've used in line:34

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fawke thank you for pointing that out. I have updated the 2 functions that will be deprecated.

Expand All @@ -38,7 +38,12 @@ export const spec = {
description: getPageDescription(),
title: localWindow.document.title || '',
w: localWindow.innerWidth,
h: localWindow.innerHeight
h: localWindow.innerHeight,
userConsent: JSON.stringify({
// case of undefined, stringify will remove param
gdprApplies: bidderRequest && bidderRequest.gdprConsent ? bidderRequest.gdprConsent.gdprApplies : undefined,
cmp: bidderRequest && bidderRequest.gdprConsent ? bidderRequest.gdprConsent.consentString : undefined
})
};

bidRequests.forEach((request) => {
Expand All @@ -55,6 +60,9 @@ export const spec = {
if (tdid) {
serverRequest.tdid = tdid;
}
if (request.schain) {
serverRequest.schain = JSON.stringify(request.schain);
}
});
serverRequest.p = '[' + serverRequest.p.toString() + ']';
return {
Expand Down Expand Up @@ -106,7 +114,7 @@ function addPlacement(request) {
const placementInfo = {
placement_id: request.adUnitCode,
callback_id: request.bidId,
sizes: request.sizes
sizes: request.mediaTypes.banner.sizes
}
if (request.params) {
if (request.params.placementId) {
Expand Down
Loading