-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add seedingAlliance Adapter #4614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this adapter.
When I tried to test the adapter with the provided test params, I was getting a CORS error against the endpoint. I have copied it below for reference:
Access to XMLHttpRequest at 'https://b.nativendo.de/cds/rtb/bid?format=openrtb2.5&ssp=nativendo' from origin 'http://test.localhost:9999' has been blocked by CORS policy: The 'Access-Control-Allow-Origin' header has a value 'http://test.localhost' that is not equal to the supplied origin.
Can you please take a look into this error?
Thanks.
Hi @jsnellbaker i have solved the problem on the server side, can you check again please? |
I just checked again. While I'm not getting the CORS error anymore, I don't seem to be getting an actual response. The request to the endpoint is completing as a 204 response. Is that expected? Below is a copy of the request payload for reference:
|
Hi @jsnellbaker not really, there was no line items for your country, i have add some. now you should see correct bids. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the update for the test bid. I checked again and saw a bid was returning.
LGTM
…idVersion1.2.0 * 'master' of https://github.com/prebid/Prebid.js: (22 commits) fix lint errors in unit test file (prebid#4702) Add Revcontent Adapter (prebid#4654) Changed data structure in Platform One Analytic Adapter (prebid#4647) increment pre version Prebid 3.2.0 Release Add static API option to the consentManagementUsp module. (prebid#4685) replace all xhr stubs with global xhr stub to prevent all requests (prebid#4687) Add CCPA us_privacy support to spotxBidAdapter (prebid#4689) ucfunnel adapter support CCPA and remove utils.js in adapter (prebid#4541) freewheelSSPBidAdapter (prebid#4645) Add CCPA support to Beachfront adapter (prebid#4673) add seedingAlliance Adapter (prebid#4614) Changed analytics data structure in YuktaMedia Analytic Adapter (prebid#4659) Add eplanning adapter for prebid 3.0 compliant and CCPA and GDPR support (prebid#4643) Bidder schain support (prebid#4551) Added CCPA support and GDPR compliance to Cedato adapter (prebid#4683) pass us privacy consent string to request (prebid#4581) Prebid 3 Admixer (prebid#4615) Pass uspConsent in bidRequest (prebid#4675) Advertly: New Bidder Adapter Submission (prebid#4496) ...
Type of change
Description of change
[email protected]
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
New seedingAlliance Adapter prebid.github.io#1701