Prebid 3 Admixer #4615
Merged
Prebid 3 Admixer #4615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # modules/admixerBidAdapter.js
jsnellbaker
requested review from
jsnellbaker
and removed request for
sumit116
jsnellbaker
requested changes
Dec 19, 2019
There was a problem hiding this comment.
Hi @AdmixerTech
Please see the comments below when you have a chance. Thanks!
modules/admixerBidAdapter.js
Outdated
| * Make a server request from the list of BidRequests. | ||
| */ | ||
| buildRequests: function (validRequest, bidderRequest) { | ||
| console.log(arguments); |
There was a problem hiding this comment.
Is this still needed?
modules/admixerBidAdapter.js
Outdated
|
|
||
| const BIDDER_CODE = 'admixer'; | ||
| const ALIASES = ['go2net']; | ||
| const ENDPOINT_URL = '//inv-nets.admixer.net/prebid.1.0.aspx'; |
There was a problem hiding this comment.
This needs to be hard-coded to https to be compliant with prebid 3.0
| import {newBidder} from 'src/adapters/bidderFactory'; | ||
|
|
||
| const BIDDER_CODE = 'admixer'; | ||
| const ENDPOINT_URL = '//inv-nets.admixer.net/prebid.1.0.aspx'; |
There was a problem hiding this comment.
This URL should be updated to https to match the corresponding request in the bidAdapter.js file.
jsnellbaker
approved these changes
Jan 2, 2020
redaguermas
added a commit
to redaguermas/Prebid.js
that referenced
this pull request
Jan 8, 2020
…idVersion1.2.0 * 'master' of https://github.com/prebid/Prebid.js: (22 commits) fix lint errors in unit test file (prebid#4702) Add Revcontent Adapter (prebid#4654) Changed data structure in Platform One Analytic Adapter (prebid#4647) increment pre version Prebid 3.2.0 Release Add static API option to the consentManagementUsp module. (prebid#4685) replace all xhr stubs with global xhr stub to prevent all requests (prebid#4687) Add CCPA us_privacy support to spotxBidAdapter (prebid#4689) ucfunnel adapter support CCPA and remove utils.js in adapter (prebid#4541) freewheelSSPBidAdapter (prebid#4645) Add CCPA support to Beachfront adapter (prebid#4673) add seedingAlliance Adapter (prebid#4614) Changed analytics data structure in YuktaMedia Analytic Adapter (prebid#4659) Add eplanning adapter for prebid 3.0 compliant and CCPA and GDPR support (prebid#4643) Bidder schain support (prebid#4551) Added CCPA support and GDPR compliance to Cedato adapter (prebid#4683) pass us privacy consent string to request (prebid#4581) Prebid 3 Admixer (prebid#4615) Pass uspConsent in bidRequest (prebid#4675) Advertly: New Bidder Adapter Submission (prebid#4496) ...
tadam75
pushed a commit
to smartadserver/Prebid.js
that referenced
this pull request
Jan 9, 2020
* BIDDER_CODE check removed * update 2.0 -> 3.0 * add spec * review_fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Re-submitting the Admixer Bid Adapter to meet the Prebid 3.0 requirements