Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bug Prebid 3.0 fail in to ConsentString #4784

Merged
merged 14 commits into from
Jan 28, 2020
Merged

Fix Bug Prebid 3.0 fail in to ConsentString #4784

merged 14 commits into from
Jan 28, 2020

Conversation

richaudience
Copy link
Contributor

Type of change

  • [ x] Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@jsnellbaker jsnellbaker self-requested a review January 28, 2020 16:52
@jsnellbaker jsnellbaker self-assigned this Jan 28, 2020
jsnellbaker
jsnellbaker approved these changes Jan 28, 2020
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit f6c4180 into prebid:master Jan 28, 2020
hellsingblack pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Mar 5, 2020
@richaudience @hellsingblack
Fix Bug Prebid 3.0 fail in to ConsentString (prebid#4784)
dd62de8 
* Support userIDs + Prebid 3.0

* Fix bug in richAudienceBidAddapter_spec.js

* Fix bug pubCommonId

* Fix bug RichaudienceAdapter

* Fix UserID5

* Fix bug ID5 change Source for Value

* Fix bug richaudienceAdapter && Add userSync pixelEnabled

* Fix bug richaudienceAdapter

* FixBug Prebid 3.0

* Fix Bug prebid 3.0 ConsentString

* Fix bug consent string

* FixBug Prebid 3.0

* FixBug Prebid 3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

Assignees

@jsnellbaker jsnellbaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richaudience @jsnellbaker