Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug Prebid 3.0 fail in to ConsentString #4784

Merged
merged 14 commits into from
Jan 28, 2020
Merged

Fix Bug Prebid 3.0 fail in to ConsentString #4784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6e5ec18
Support userIDs + Prebid 3.0
richaudience Nov 26, 2019
9af593d
Fix bug in richAudienceBidAddapter_spec.js
richaudience Nov 26, 2019
661effd
Fix bug pubCommonId
richaudience Nov 26, 2019
9bf6381
Fix bug RichaudienceAdapter
richaudience Nov 29, 2019
ca1728a
Fix UserID5
richaudience Dec 2, 2019
5774bf8
Fix bug ID5 change Source for Value
richaudience Dec 3, 2019
0378054
Fix bug richaudienceAdapter && Add userSync pixelEnabled
richaudience Dec 5, 2019
378be24
Fix bug richaudienceAdapter
richaudience Dec 5, 2019
df7dfff
FixBug Prebid 3.0
richaudience Jan 27, 2020
1d68193
Fix Bug prebid 3.0 ConsentString
richaudience Jan 27, 2020
ec5bdd5
Fix bug consent string
richaudience Jan 27, 2020
fdef29e
Merge branch 'master' of https://github.com/richaudience/Prebid.js
richaudience Jan 27, 2020
5e28853
FixBug Prebid 3.0
richaudience Jan 27, 2020
e364747
FixBug Prebid 3.0
richaudience Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/richaudienceBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,10 @@ export const spec = {
url: syncUrl
});
} else if (syncOptions.pixelEnabled && REFERER != null) {
typeof gdprConsent.consentString != 'undefined' ? syncUrl = `https://sync.richaudience.com/bf7c142f4339da0278e83698a02b0854/?euconsent=${gdprConsent.consentString}&referrer=${REFERER}` : syncUrl = `https://sync.richaudience.com/bf7c142f4339da0278e83698a02b0854/?referrer=${REFERER}`;
syncs.push({
type: 'image',
url: `https://sync.richaudience.com/bf7c142f4339da0278e83698a02b0854/?euconsent=${gdprConsent.consentString}&referrer=${REFERER}`
url: syncUrl
});
}
return syncs
Expand Down
10 changes: 10 additions & 0 deletions test/spec/modules/richaudienceBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,5 +667,15 @@ describe('Richaudience adapter tests', function () {
})
expect(syncs).to.have.lengthOf(1);
expect(syncs[0].type).to.equal('image');

syncs = spec.getUserSyncs({
pixelEnabled: true
}, [], {
consentString: null,
referer: 'http://domain.com',
gdprApplies: true
})
expect(syncs).to.have.lengthOf(1);
expect(syncs[0].type).to.equal('image');
});
});