Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnderdogMedia Adapter #491

Merged
merged 1 commit into from
Aug 9, 2016
Merged

Add UnderdogMedia Adapter #491

merged 1 commit into from
Aug 9, 2016

Conversation

baragona
Copy link
Contributor

Hello,

We would like to add an adapter to support our Bidding API. The tests included use a mocked implementation of our Bidding API, therefore no contact with our server is needed to run the tests.

Here are the parameters our adapter supports:

  • bidfloor (optional)
  • siteId (required)

Here are some parameters than anyone is free to use to test our adapter:

{
    bidder: 'underdogmedia',
    params: {
       siteId: '10272'
    }
}

It should consistently return test bids for at least the 728x90, 300x250, 160x600 ad sizes.

If anyone has issues with this adapter please contact us at: [email protected]

Thanks,
Underdog Media

@protonate protonate self-assigned this Aug 9, 2016
@protonate
Copy link
Collaborator

Reviewed, code looks good, tests are green, ads are returned. Thanks for the contribution.

@protonate protonate merged commit ff3c2f0 into prebid:master Aug 9, 2016
for(var i = 0; i < bidResponse.bids.length; i++){
var udm_bid = bidResponse.bids[i];
var bid = bidfactory.createBid(1);
bid.bidderCode = bidRequest.bidder;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that PR #498 allows for passing a bid request when creating a bid response so that the IDs match. See that PR for details.

@snapwich
Copy link
Collaborator

This spec includes the "qs" npm module but is not specified in package.json. Might want to add it.

olafbuitelaar pushed a commit to olafbuitelaar/Prebid.js that referenced this pull request Aug 13, 2016
protonate pushed a commit that referenced this pull request Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants