Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ex 3448 #7928

Closed
wants to merge 15 commits into from
Closed

Ex 3448 #7928

wants to merge 15 commits into from

Conversation

cpabst
Copy link
Contributor

@cpabst cpabst commented Jan 10, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Adding support for Video to the Sovrn bid adapter

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

prebid/prebid.github.io#3492
prebid/prebid.github.io#3493

Other information

Mikhalovich and others added 15 commits January 10, 2022 12:43
* Ventes Avenues initial changes

* Ventes Avenues initial changes

* Support Web Placments

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placments
…SON modules (prebid#7774)

* fix: Webpack v5 complain about named export from JSON modules

* Index Exchange Adapter: fix "Should not import the named export 'EVENTS'.'AUCTION_DEBUG' (imported as 'EVENTS') from default-exporting module (only default export is available soon)""

Co-authored-by: Javier Marín <[email protected]>
This reverts commit 8b42386, reversing
changes made to 0b24b9c.
* Ventes Avenues initial changes

* Ventes Avenues initial changes

* Support Web Placments

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placments
…SON modules (prebid#7774)

* fix: Webpack v5 complain about named export from JSON modules

* Index Exchange Adapter: fix "Should not import the named export 'EVENTS'.'AUCTION_DEBUG' (imported as 'EVENTS') from default-exporting module (only default export is available soon)""

Co-authored-by: Javier Marín <[email protected]>
@cpabst
Copy link
Contributor Author

cpabst commented Jan 10, 2022

This is not right either.

@cpabst cpabst closed this Jan 10, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jan 10, 2022

This pull request introduces 2 alerts and fixes 4 when merging 3fcf028 into 44f6bdb - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Invocation of non-function

fixed alerts:

  • 3 for Superfluous trailing arguments
  • 1 for Unneeded defensive code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants