-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOVRN - Video parameters and examples #3493
Conversation
Not ready for review yet. |
This is ready for review now. |
@@ -22,3 +22,160 @@ fpd_supported: true | |||
|------------|----------|----------------------|------------|----------| | |||
| `tagid` | required | The sovrn Ad Tag ID | `'315045'` | `string` | | |||
| `bidfloor` | optional | Bid floor in dollars | `'0.04'` | `string` | | |||
|
|||
### Bid Params for video ads | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a note indicating that these video parameters go in mediatype.video rather than your bidder-specific params.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be picky, but please move 'These params should be added to mediatype.video
.' out of the heading level 3. That will make the formatting rather awkward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bretg Is this what you were looking for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please add this to the metadata at the top of the file
media_types: banner, video
Hi, if you make the edits @bretg requested I can merge your PR. |
@cpabst ping |
I'll be looking at this today. |
✔️ Deploy Preview for prebid-docs-preview ready! 🔨 Explore the source changes: 342e68e 🔍 Inspect the deploy log: https://app.netlify.com/sites/prebid-docs-preview/deploys/6229096b0f2f6d0008233d89 😎 Browse the preview: https://deploy-preview-3493--prebid-docs-preview.netlify.app |
Sorry this took so long. Ready for re-review. |
|
||
### Note | ||
|
||
[Protocols list](https://docs.prebid.org/dev-docs/bidders/conversant.html#protocols) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it confusing that you're referring to Conversant's protocols but copy all the rest of the dimensional values here. But this has been open for so long, I'll merge this and let you decide whether you want to fix.
@bretg Thank you. Sorry this took so long. |
* EX-3450 Create Sovrn docs on how to use prebid video * EX-3450 Add all supported fields for video ad * EX-3450 Fix table * EX-3450: Remove incorrect iOS information * EX-3450: PR update * SOVRN: PR update Co-authored-by: mikhalovich <[email protected]>
No description provided.