adbund adapter #932
Merged
adbund adapter #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove this comment; Use adloader.loadScript function; use CONSTANTS
|
@AdBund Please add unit tests |
jaiminpanchal27
requested changes
Jan 24, 2017
| ua: window.navigator.userAgent | ||
| }; | ||
| var param = Object.assign({}, bid.params, info); | ||
| param.sizes = JSON.stringify(param.sizes || bid.sizes); |
There was a problem hiding this comment.
I am getting bid back for size [[300,250]] but not for [300,250]. Please add support for the same.
There was a problem hiding this comment.
Has been modified, please review again
|
This is a what's wrong? @jaiminpanchal27
|
test/spec/adapters/adbund_spec.js
Outdated
| @@ -0,0 +1,102 @@ | |||
| import { expect } from 'chai'; | |||
| import Adapter from '../../../src/adapters/adbund'; | |||
| import adapterManager from 'src/adaptermanager'; | |||
There was a problem hiding this comment.
import of adaptermanager is causing the problem. Remove this line.
You can check https://github.com/prebid/Prebid.js/blob/master/test/spec/adapters/hiromedia_spec.js
jaiminpanchal27
approved these changes
Feb 28, 2017
|
Looks good. Thanks @AdBund |
|
This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing |
|
Added adbund. md to dev-docs directory.Thanks |
Walexander
pushed a commit
to MbidIO/Prebid.js
that referenced
this pull request
Mar 6, 2017
* add adBund Adaptor * 更改正式接口地址 * change code style;add param(referrer,domain,ua) * add test in pbjs_example_gpt.html * change code style * Convert this comment to english; Remove this comment; Use adloader.loadScript function; use CONSTANTS * add unit tests * 移除gpt示例中的sizes可选参数 * tabs to spaces * change unit tests * change unit tests * change unit tests * change unit tests * change unit tests * change unit tests * change unit tests
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
May 19, 2017
…18.0 to aolgithub-master * commit '2881f03dd76bfcf484fbfeaf0f9e1000b383d20d': Added adapters in aolPartnersIds.json. Added changelog entry. Prebid 0.20.0 Release Remove test that intermittently fails unit tests (prebid#1020) Create bids for requests without mutating ad units (prebid#1019) Use optimize js to improve parse time (https://github.com/nolanlawson/optimize-js) (prebid#1018) Fixes for Centro adapter (prebid#992) adbund adapter (prebid#932) Fix bug with supporting non-cpm dealId bids. (prebid#1006) Added referrer parameter (prebid#966) Support Video for GetIntent adapter (prebid#987) Currency support for SmartAdServer adapter (prebid#979) Deal support for SmartAdServer adapter (prebid#978) Skip test causing build failures (prebid#997) E2etest concurrency (prebid#982) Add ThoughtLeadr adapter (prebid#894) Increment Pre Version
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
May 22, 2017
…18.0 to master * commit '2881f03dd76bfcf484fbfeaf0f9e1000b383d20d': Added adapters in aolPartnersIds.json. Added changelog entry. Prebid 0.20.0 Release Remove test that intermittently fails unit tests (prebid#1020) Create bids for requests without mutating ad units (prebid#1019) Use optimize js to improve parse time (https://github.com/nolanlawson/optimize-js) (prebid#1018) Fixes for Centro adapter (prebid#992) adbund adapter (prebid#932) Fix bug with supporting non-cpm dealId bids. (prebid#1006) Added referrer parameter (prebid#966) Support Video for GetIntent adapter (prebid#987) Currency support for SmartAdServer adapter (prebid#979) Deal support for SmartAdServer adapter (prebid#978) Skip test causing build failures (prebid#997) E2etest concurrency (prebid#982) Add ThoughtLeadr adapter (prebid#894) Increment Pre Version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Other information