Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test causing build failures #997

Merged
merged 1 commit into from
Feb 17, 2017
Merged

Skip test causing build failures #997

merged 1 commit into from
Feb 17, 2017

Conversation

matthewlane
Copy link
Collaborator

Type of change

  • Test fix

Description of change

The post message test in thoughleadr spec is occasionally causing build failures

Chrome 56.0.2924 (Linux 0.0.0) thoughtleadr adapter tests requestPlacement should response on the postMessage request FAILED
    Error: timeout of 2000ms exceeded
        at /home/travis/build/prebid/Prebid.js/test/spec/adapters/thoughtleadr_spec.js:211:12

The condition is difficult to reproduce so skipping this test for now

Other information

cc @ilya-pirogov @Shakakai

@matthewlane matthewlane merged commit feceeec into master Feb 17, 2017
@matthewlane matthewlane deleted the skip-failing-test branch February 22, 2017 22:38
Walexander pushed a commit to MbidIO/Prebid.js that referenced this pull request Mar 6, 2017
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request May 19, 2017
…18.0 to aolgithub-master

* commit '2881f03dd76bfcf484fbfeaf0f9e1000b383d20d':
  Added adapters in aolPartnersIds.json.
  Added changelog entry.
  Prebid 0.20.0 Release
  Remove test that intermittently fails unit tests (prebid#1020)
  Create bids for requests without mutating ad units (prebid#1019)
  Use optimize js to improve parse time (https://github.com/nolanlawson/optimize-js) (prebid#1018)
  Fixes for Centro adapter (prebid#992)
  adbund adapter (prebid#932)
  Fix bug with supporting non-cpm dealId bids. (prebid#1006)
  Added referrer parameter (prebid#966)
  Support Video for GetIntent adapter (prebid#987)
  Currency support for SmartAdServer adapter (prebid#979)
  Deal support for SmartAdServer adapter (prebid#978)
  Skip test causing build failures (prebid#997)
  E2etest concurrency (prebid#982)
  Add ThoughtLeadr adapter (prebid#894)
  Increment Pre Version
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request May 22, 2017
…18.0 to master

* commit '2881f03dd76bfcf484fbfeaf0f9e1000b383d20d':
  Added adapters in aolPartnersIds.json.
  Added changelog entry.
  Prebid 0.20.0 Release
  Remove test that intermittently fails unit tests (prebid#1020)
  Create bids for requests without mutating ad units (prebid#1019)
  Use optimize js to improve parse time (https://github.com/nolanlawson/optimize-js) (prebid#1018)
  Fixes for Centro adapter (prebid#992)
  adbund adapter (prebid#932)
  Fix bug with supporting non-cpm dealId bids. (prebid#1006)
  Added referrer parameter (prebid#966)
  Support Video for GetIntent adapter (prebid#987)
  Currency support for SmartAdServer adapter (prebid#979)
  Deal support for SmartAdServer adapter (prebid#978)
  Skip test causing build failures (prebid#997)
  E2etest concurrency (prebid#982)
  Add ThoughtLeadr adapter (prebid#894)
  Increment Pre Version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants