Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TravisCI #1523

Closed
wants to merge 2 commits into from
Closed

Remove TravisCI #1523

wants to merge 2 commits into from

Conversation

SyntaxNode
Copy link
Contributor

We've had several issues with TravisCI this year, including:

  • Failing to report build results to GitHub.
  • Inconsistencies in UI permission where maintainers are not always able to restart a build.
  • Timeouts during Go module retrieval.

@laurb9 introduced the ability to use GitHub Actions which has been a huge success. I propose now's the time to officially switch over.

FYI: The current build issues (intermittent failures) are unrelated to TravisCI. There's a race condition within a test. We are confident this is just a problem with the test, and not with the code its testing. This will be resolved by #1522.

@@ -6,7 +6,7 @@ on:
release:
types:
- created
name: Validate
name: validate
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mixed case here is showing up in the GitHub UI. I'd like to change it to all lowercase for consistency with the file name and it's more common practice to use all lowercase for build tasks.

api_key:
secure: TSJcbIpg2zTJuzUXwv0Un5DPztDTeIKQ2BuuO9KiWYY3Td/nKn0flTYE6B5O6iVqE96HKyj2j0W51rhnRTNDReRZv76L+YXLTJOTQEEQY/A+7XaUXRT0KIbr1EHaeU+4uPJe/8YXxq+nFNeqOjj+LY457WbvnQTIbraAmCgi4yNq4JR+J9BoCELkX0SnU7oq+brq9tJNL3V+7EHIVH6ZLa1lWOrapMnbrVils8gwzWR8XpbdaI+Sn30AGOFKZ0WE2ojZkZb8oZxyX0HKarIiykfZUUzRhlXlTJ0D81QOdc5AtPNR/2dqUXsUE8mRav9R3AJM2BCS2pnP29orCRQU/kxS/mRfx2oZhkr+OHPsNbJcGNSbqNKlM13bX2nL1ZJsJ6xL0VrkBFYlI01SWR12CT9DhZSqTmGPNEkt3fdzwuYtkJNfthb9e9obscnmJEHPSiZRv9dv/stP5LVJJHfFdrzM4+Qo3MCxLNOhmc+p93gsZPeuDGDlx8Tqv1KpN7sp0glbmOwyFAwbCVh5can/JPIAKsQi9VRyZAJvn+7sqqZCExN4TvFArq7pe0LjIVHUQZP9g/vS8HobQnPutmGxf8HqzVVEBnjMsXuiY4cVRecXVRM7crfJjLGr2e9ywIkUZMSD+bRkbRUZ0QQQPvWtcgRw5JmLKG9jDklj8BDkON8=
file:
- prebid-server_linux_386
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone actually use this binary instead of the Docker image? We could create a new GitHub action to build it, but do we really need to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hearing that we should keep it. I'll update this PR to add a new GitHub Action to build the binaries.

@bsardo
Copy link
Collaborator

bsardo commented Oct 8, 2020

LGTM other than the Github Action to build the binaries.

@guscarreon
Copy link
Contributor

LGTM, but conflicts in README.md should be resolved.

@stale
Copy link

stale bot commented Oct 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 22, 2020
@SyntaxNode SyntaxNode closed this Nov 16, 2020
@SyntaxNode SyntaxNode deleted the kill_travis branch January 23, 2021 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants