Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TravisCI #1523

Closed
wants to merge 2 commits into from
Closed

Remove TravisCI #1523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63e7e8d
Remove TravisCI
SyntaxNode Oct 6, 2020
d7f52e7
Update Readme
SyntaxNode Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
release:
types:
- created
name: Validate
name: validate
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mixed case here is showing up in the GitHub UI. I'd like to change it to all lowercase for consistency with the file name and it's more common practice to use all lowercase for build tasks.

jobs:
Go:
strategy:
Expand All @@ -21,7 +21,7 @@ jobs:
go-version: ${{ matrix.go-version }}
- name: Checkout code
uses: actions/checkout@v2
- name: Validate
- name: validate
run: |
./validate.sh --nofmt --cov --race 10
env:
Expand Down
30 changes: 0 additions & 30 deletions .travis.yml
View file
Open in desktop

This file was deleted.

12 changes: 8 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[![Build Status](https://travis-ci.org/prebid/prebid-server.svg?branch=master)](https://travis-ci.org/prebid/prebid-server)
[![Validate Actions Status](https://github.com/prebid/prebid-server/workflows/validate/badge.svg)](https://github.com/prebid/prebid-server/actions?query=workflow%3Avalidate)
[![Go Report Card](https://goreportcard.com/badge/github.com/prebid/prebid-server?style=flat-square)](https://goreportcard.com/report/github.com/prebid/prebid-server)

# Prebid Server
Expand Down Expand Up @@ -48,10 +48,14 @@ Load the landing page in your browser at `http://localhost:8000/`.
For the full API reference, see [the endpoint documentation](https://docs.prebid.org/prebid-server/endpoints/pbs-endpoint-overview.html)


## Run On Docker

Docker images for Prebid Server are available from [DockerHub](https://hub.docker.com/r/prebid/prebid-server/). We build and publish official images for every release. The base image is [ubuntu:18.04](https://hub.docker.com/_/ubuntu).

## Contributing

Want to [add an adapter](https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html)? Found a bug? Great!
Want to [add an adapter](https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html)? Found a bug? We welcome you to join our developer community.

Report bugs, request features, and suggest improvements [on Github](https://github.com/prebid/prebid-server/issues).
Report bugs, propose features, or suggest improvements [on the GitHub issues page](https://github.com/prebid/prebid-server/issues). Develop a new adapter following [our guide](https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html) and open a pull request.

Or better yet, [open a pull request](https://github.com/prebid/prebid-server/compare) with the changes you'd like to see.
Interested in implementing a defined feature? You're welcome to pick up an intent-to-implement story from the [issue list](https://github.com/prebid/prebid-server/issues?q=is%3Aissue+is%3Aopen+label%3A%22Intent+to+implement%22) and begin work. Please mention in the issue that you're working on it to avoid duplicated effort.
2 changes: 1 addition & 1 deletion docs/developers/automated-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Automated Tests

This project uses [TravisCI](https://travis-ci.org/) to make sure that every PR passes automated tests.
This project uses [GitHub Actions](https://github.com/features/actions) to make sure that every PR passes automated tests.
To reproduce these tests locally, use:

```
Expand Down
2 changes: 1 addition & 1 deletion docs/developers/contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ those updates must be submitted in the same Pull Request as the code changes.
When you're ready, [submit a Pull Request](https://help.github.com/articles/creating-a-pull-request/)
against the `master` branch of [our GitHub repository](https://github.com/prebid/prebid-server/compare).

Pull Requests will be vetted through [Travis CI](https://travis-ci.com/).
Pull Requests will be vetted through [GitHub Actions](https://github.com/features/actions).
To reproduce these same tests locally, do:

```bash
Expand Down
4 changes: 2 additions & 2 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (
// Rev holds binary revision string
// Set manually at build time using:
// go build -ldflags "-X main.Rev=`git rev-parse --short HEAD`"
// Populated automatically at build / release time via .travis.yml
// Populated automatically at build / release time via the Dockerfile
// `gox -os="linux" -arch="386" -output="{{.Dir}}_{{.OS}}_{{.Arch}}" -ldflags "-X main.Rev=`git rev-parse --short HEAD`" -verbose ./...;`
// See issue #559
var Rev string
Expand Down Expand Up @@ -55,7 +55,7 @@ func serve(revision string, cfg *config.Configuration) error {
fetchingInterval := time.Duration(cfg.CurrencyConverter.FetchIntervalSeconds) * time.Second
staleRatesThreshold := time.Duration(cfg.CurrencyConverter.StaleRatesSeconds) * time.Second
currencyConverter := currencies.NewRateConverter(&http.Client{}, cfg.CurrencyConverter.FetchURL, staleRatesThreshold)

currencyConverterTickerTask := task.NewTickerTask(fetchingInterval, currencyConverter)
currencyConverterTickerTask.Start()

Expand Down