Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter: apacdex and Remove Adapter: valueimpression #2097

Merged
merged 10 commits into from
Dec 20, 2021
Merged

New Adapter: apacdex and Remove Adapter: valueimpression #2097

merged 10 commits into from
Dec 20, 2021

Conversation

thuyhq
Copy link
Contributor

@thuyhq thuyhq commented Nov 26, 2021

Similar to the adapter on Prebid.js, we want to use apacdex as our primary adapter and quantumdex, valueimpression will become the alias.
So I renamed the valueimpression adapter to apacdex and updated a few things:
Update adapter endpoint.
Update usersync url and support both iframe and redirect.
Support bidder params: placementId, floorPrice

@thuyhq thuyhq mentioned this pull request Nov 26, 2021
Merged
@SyntaxNode SyntaxNode changed the title Add New Adapter: apacdex and Remove Adapter: valueimpression New Adapter: apacdex and Remove Adapter: valueimpression Nov 29, 2021
@thuyhq thuyhq requested a review from SyntaxNode November 30, 2021 03:01
mansinahar
mansinahar reviewed Nov 30, 2021
View reviewed changes
config/config.go Show resolved Hide resolved
exchange/adapter_builders.go Show resolved Hide resolved
openrtb_ext/bidders.go Outdated Show resolved Hide resolved
@thuyhq
Copy link
Contributor Author

thuyhq commented Dec 1, 2021

Hello @mansinahar,
Thank you for review.
I made the change with the alias Valueimpression and did the same thing so that Quantumdex became the alias of the Apacdex adapter.

VeronikaSolovei9
VeronikaSolovei9 reviewed Dec 2, 2021
View reviewed changes
Copy link
Contributor

@VeronikaSolovei9 VeronikaSolovei9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, can see requests to all 3 adapters in logs. Added 2 minor comments

adapters/apacdex/apacdex.go Outdated Show resolved Hide resolved
adapters/apacdex/apacdex.go Show resolved Hide resolved
config/config.go Show resolved Hide resolved
@thuyhq
Copy link
Contributor Author

thuyhq commented Dec 2, 2021

Hi @VeronikaSolovei9,
Thank you for review!

VeronikaSolovei9
VeronikaSolovei9 previously approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@VeronikaSolovei9 VeronikaSolovei9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing comments, looks good

mansinahar
mansinahar reviewed Dec 8, 2021
View reviewed changes
adapters/apacdex/apacdex.go Outdated Show resolved Hide resolved
adapters/apacdex/apacdex.go Outdated Show resolved Hide resolved
config/config.go Show resolved Hide resolved
openrtb_ext/bidders.go Show resolved Hide resolved
VeronikaSolovei9
VeronikaSolovei9 previously approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@VeronikaSolovei9 VeronikaSolovei9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mansinahar
Copy link
Contributor

@thuyhq Not sure if you noticed my response on the above comment or not. Just wanna bring your attention to that. Let us know if you'll be taking care of that as part of this PR or a separate PR in the future. Thanks!

@thuyhq
Copy link
Contributor Author

thuyhq commented Dec 16, 2021

Hi @mansinahar,
Sorry for the late reply.
It took me some time to update my endpoint side.
Thank you for keeping an eye on.

@mansinahar
Copy link
Contributor

Hi @mansinahar, Sorry for the late reply. It took me some time to update my endpoint side. Thank you for keeping an eye on.

No worries @thuyhq! I am looking at the changes you made and I noticed that you're trying to read the media type from bidresponse.seatbid.bid[i].ext.pbs.mediatype. Can I ask why can't se just used the already existing bidresponse.seatbid.bid[i].ext.prebid.type?

You can then just do something like: https://github.com/prebid/prebid-server/blob/master/adapters/adf/adf.go#L143

@thuyhq
Copy link
Contributor Author

thuyhq commented Dec 17, 2021

Hi @mansinahar,
I'm just doing the same as the appnexus adapter

prebid-server/adapters/appnexus/appnexus.go

Line 421 in a60dfe2

func getMediaTypeForBid(bid *appnexusBidExt) (openrtb_ext.BidType, error) {

and i think the openrtb_ext.ExtBid extension is only for the prebid-serve endpoint bid response.

I edited it according to your suggestion.
Thank you.

mansinahar
mansinahar reviewed Dec 17, 2021
View reviewed changes
Copy link
Contributor

@mansinahar mansinahar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the minor comment below

adapters/apacdex/apacdex.go Outdated Show resolved Hide resolved
@VeronikaSolovei9 VeronikaSolovei9 merged commit 61ece35 into prebid:master Dec 20, 2021
wwwyyy pushed a commit to wwwyyy/prebid-server that referenced this pull request Jan 18, 2022
Merge branch 'master' of https://github.com/wwwyyy/prebid-server
0678a70 
* 'master' of https://github.com/wwwyyy/prebid-server:
  GDPR: pass geo based on special feature 1 opt-in (prebid#2122)
  Adyoulike: Fix adapter errors if no content (prebid#2134)
  Update adyoulike.yaml (prebid#2131)
  Add ORTB 2.4 schain support (prebid#2108)
  Stored response fetcher (with new func for stored resp) (prebid#2099)
  Adot: Add OpenRTB macros resolution (prebid#2118)
  Rubicon adapter: accept accountId, siteId, zoneId as strings (prebid#2110)
  Operaads: support multiformat request (prebid#2121)
  Update go-gdpr to v1.11.0 (prebid#2125)
  Adgeneration: Update request to include device and app related info in headers and query params (prebid#2109)
  Adnuntius: Read device information from ortb Request (prebid#2112)
  New Adapter: apacdex and Remove Adapter: valueimpression (prebid#2097)
  New Adapter: Compass (prebid#2102)
  Orbidder: bidfloor currency handling (prebid#2093)
jorgeluisrocha pushed a commit to jwplayer/prebid-server that referenced this pull request Sep 28, 2022
@thuyhq @jorgeluisrocha
New Adapter: apacdex and Remove Adapter: valueimpression (prebid#2097)
7de7c43 
Valueimpression to become apacdex adapter
shunj-nb pushed a commit to ParticleMedia/prebid-server that referenced this pull request Nov 8, 2022
@thuyhq @shunj-nb
New Adapter: apacdex and Remove Adapter: valueimpression (prebid#2097)
56c0f78 
Valueimpression to become apacdex adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansinahar mansinahar mansinahar approved these changes

@VeronikaSolovei9 VeronikaSolovei9 VeronikaSolovei9 approved these changes

@SyntaxNode SyntaxNode Awaiting requested review from SyntaxNode

Assignees

@VeronikaSolovei9 VeronikaSolovei9

@mansinahar mansinahar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thuyhq @mansinahar @SyntaxNode @VeronikaSolovei9