Adgeneration: Update request to include device and app related info in headers and query params #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: fix sizes query.
…est-params FIX: makeBidRequestの不備
# Conflicts: # adapters/adgeneration/adgeneration.go
…dgeneration1.0.3_inhouse adding request parameter
mansinahar
changed the title
|
@banakemi Can you please fix the tests for this PR and also add JSON tests for the changes made in this PR? Thanks! |
…dgeneration1.0.3_inhouse update test
|
Hi @mansinahar |
mansinahar
reviewed
Dec 17, 2021
| if request.Device != nil { | ||
| if len(request.Device.UA) > 0 { | ||
| headers.Add("User-Agent", request.Device.UA) | ||
| } |
There was a problem hiding this comment.
@banakemi Can you please also add/modify existing JSON tests for the changes you've made in this file?
There was a problem hiding this comment.
@mansinahar
Thank you. I fixed it.
AlexBVolcy
reviewed
Dec 20, 2021
| v.Set("sdktype", "2") | ||
| } else { | ||
| v.Set("sdktype", "0") | ||
| } |
There was a problem hiding this comment.
Just want to reiterate the need for json tests for these new conditionals!
| v.Set("sdktype", "2") | ||
| } else { | ||
| v.Set("sdktype", "0") | ||
| } | ||
| if request.Site != nil && request.Site.Page != "" { | ||
| v.Set("tp", request.Site.Page) | ||
| } | ||
| if request.Source != nil && request.Source.TID != "" { | ||
| v.Set("transactionid", request.Source.TID) |
There was a problem hiding this comment.
This line isn't new code, but I checked the test coverage and it isn't covering this case, so we'll need a json test for this too!
There was a problem hiding this comment.
@AlexBVolcy
Thank you. I fixed it.
…adgeneration1.0.3_inhouse update test
AlexBVolcy
approved these changes
Jan 5, 2022
mansinahar
approved these changes
Jan 6, 2022
wwwyyy
pushed a commit
to wwwyyy/prebid-server
that referenced
this pull request
Jan 18, 2022
* 'master' of https://github.com/wwwyyy/prebid-server: GDPR: pass geo based on special feature 1 opt-in (prebid#2122) Adyoulike: Fix adapter errors if no content (prebid#2134) Update adyoulike.yaml (prebid#2131) Add ORTB 2.4 schain support (prebid#2108) Stored response fetcher (with new func for stored resp) (prebid#2099) Adot: Add OpenRTB macros resolution (prebid#2118) Rubicon adapter: accept accountId, siteId, zoneId as strings (prebid#2110) Operaads: support multiformat request (prebid#2121) Update go-gdpr to v1.11.0 (prebid#2125) Adgeneration: Update request to include device and app related info in headers and query params (prebid#2109) Adnuntius: Read device information from ortb Request (prebid#2112) New Adapter: apacdex and Remove Adapter: valueimpression (prebid#2097) New Adapter: Compass (prebid#2102) Orbidder: bidfloor currency handling (prebid#2093)
ramyferjaniadot
pushed a commit
to adotmob/prebid-server
that referenced
this pull request
Feb 2, 2022
…n headers and query params (prebid#2109)
jorgeluisrocha
pushed a commit
to jwplayer/prebid-server
that referenced
this pull request
Sep 28, 2022
…n headers and query params (prebid#2109)
shunj-nb
pushed a commit
to ParticleMedia/prebid-server
that referenced
this pull request
Nov 8, 2022
…n headers and query params (prebid#2109)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adding ad request parameters.