Fix for storedauctionresponse bid type #2615
Conversation
VeronikaSolovei9
changed the title
exchange/exchange.go
Outdated
| @@ -1280,6 +1280,20 @@ func listBiddersWithRequests(bidderRequests []BidderRequest) []openrtb_ext.Bidde | |||
| return liveAdapters | |||
| } | |||
|
|
|||
| func getMediaTypeForBid(bid openrtb2.Bid) (openrtb_ext.BidType, error) { | |||
There was a problem hiding this comment.
Nitpick: Consider changing the name to getPrebidMediaTypeForBid to clarify what field this method is extracting.
exchange/exchange.go
Outdated
| mType := seat.Bid[i].MType | ||
| var bidType openrtb_ext.BidType | ||
| if mType > 0 { | ||
| bidType = openrtb_ext.BidTypes()[mType-1] |
There was a problem hiding this comment.
Please validate the mtype is valid (if greater than 0). If it's not valid, consider responding with the same BadServerResponse message.
| var err error | ||
| bidType, err = getPrebidMediaTypeForBid(seat.Bid[i]) | ||
| if err != nil { | ||
| return nil, nil, nil, err |
There was a problem hiding this comment.
This error case has no test coverage.
There was a problem hiding this comment.
Added.
Are we ok to return error as is from ParseBidType? Or is it better convert it to BadServerResponse for consistency?
There was a problem hiding this comment.
I don't have a strong opinion on this. I do like consistency and support you on that.
There was a problem hiding this comment.
Discussed offline. No changes needed.
Fix for #2614