Adapt Docker workflow #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 2, 2023 19:52
- make the manual triggering more useful - move latest tag to last master
MakisH
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Looks good to me, and I feel that it is fixing some bugs, independent of the system tests. Thanks, @valentin-seitz!
@IshaanDesai please also have a look. I leave the merging to you.
Co-authored-by: Gerasimos Chourdakis <[email protected]>
Co-authored-by: Gerasimos Chourdakis <[email protected]>
IshaanDesai
requested changes
Aug 3, 2023
MakisH
approved these changes
Aug 9, 2023
|
Looking at the published image on Docker Hub, the images with tags After being merged to master, this PR will change the |
IshaanDesai
approved these changes
Aug 9, 2023
This was referenced Feb 6, 2024
BenjaminRodenberg
pushed a commit
that referenced
this pull request
Aug 27, 2024
* - modify args to fit to systemtest - make the manual triggering more useful - move latest tag to last master * bash string handling... Fun stuff * sprinkle in some " * adding some "debug" ouptut * Update .github/workflows/build-docker.yml Co-authored-by: Gerasimos Chourdakis <[email protected]> * Update .github/workflows/build-docker.yml Co-authored-by: Gerasimos Chourdakis <[email protected]> --------- Co-authored-by: Valentin Seitz <[email protected]> Co-authored-by: Gerasimos Chourdakis <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Dec 5, 2024
* Lint markdown files and update files correspondingly. (#180) * Add Cython as dependency required during installation (#177) * Adapt Docker workflow according to new system tests design (#186) - modify args to fit to systemtest - make the manual triggering more useful - move latest tag to last master * bash string handling... Fun stuff * sprinkle in some " * adding some "debug" ouptut * Update .github/workflows/build-docker.yml * Require setuptools>=61 (#207) * Restrict to numpy < 2 and setuptools < 72 for better compatibiltiy with CI pipeline (#213) * Simplify setup.py w.r.t noisy warning (always shown when building with spack). * Use Ubuntu 24.04. * Explicitly specify docker image tags in CI. * use spack base image precice/ci-spack-pyprecice-deps-2404:2.5.1.0 * use precice base image precice/precice:2.5.1 * Add entry in changelog. * Fix spack workflow for 2.5.1.0. * Add branch for release candidate of 2.5.1.0 * Update build dependencies for release candidate * Use PyPI token instead of username and password in the package publishing action --------- Co-authored-by: Ishaan Desai <[email protected]> Co-authored-by: valentin-seitz <[email protected]> Co-authored-by: Valentin Seitz <[email protected]> Co-authored-by: Gerasimos Chourdakis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts the current Dockerfile to match
latestbeeing used for the latest stable release -> master branchThis is also needed in the downstream components like the fenics-adapter (Build
latestdocker container from master notdevelopbranch fenics-adapter#161)It also introduces a manual triggering of the rebuilt process.
Please note: the
pushworkflow trigger mechanism could not be tested.