Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving cache taking too long #113

Merged
merged 5 commits into from
May 23, 2024
Merged

Conversation

0xbe7a
Copy link
Contributor

@0xbe7a 0xbe7a commented May 23, 2024

Fixes #91

When setting up a new Pixi environment for the first time, the setup-pixi action currently hangs for up to several minutes, appearing to do nothing. An example can be seen here: https://github.com/Quantco/multiregex/actions/runs/9207365813/job/25327248270.

This issue seems to be caused by an unresolved problem in actions/toolkit, which prevents actions from terminating in a timely manner after uploading a new cached artifact, as discussed here: actions/toolkit#1578. A workaround is to force the process to terminate by adding process.exit(0) at the end of the execution.

@0xbe7a 0xbe7a requested a review from pavelzw as a code owner May 23, 2024 12:09
src/main.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🥳
image

@pavelzw pavelzw added the bug Something isn't working label May 23, 2024
@pavelzw pavelzw changed the title force termination with process.exit() Fix saving cache taking too long May 23, 2024
@pavelzw pavelzw merged commit 2058dcd into prefix-dev:main May 23, 2024
122 of 125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document why setup-pixi is so slow when uploading cache
2 participants