Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that quoted identifiers remain quoted in formatter #17406

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make sure that quoted identifiers remain quoted in formatter #17406

wants to merge 1 commit into from

Conversation

v-jizhang
Copy link
Contributor

Cherry-pick of trinodb/trino#11171
The SqlFormatter effectively drops quotes from the quoted identifiers
when formatting 'SET SESSION' statement.
This causes valid queries to fail: e.g. SET SESSION
"name-suffix".property = 'value' PrestoException: Formatted query does
not parse even when identifier (name-suffix) is quoted.

Follow up #17186

Co-authored-by: Sergey Melnychuk [email protected]

Test plan - Added a test

== RELEASE NOTES ==

General Changes
* Make sure that quoted identifiers remain quoted in formatter

@v-jizhang
Make sure that quoted identifiers remain quoted in formatter
d31c45a 
Cherry-pick of trinodb/trino#11171
The SqlFormatter effectively drops quotes from the quoted identifiers
when formatting 'SET SESSION' statement.
This causes valid queries to fail: e.g. SET SESSION
"name-suffix".property = 'value' PrestoException: Formatted query does
not parse even when identifier (name-suffix) is quoted.

Follow up prestodb#17186

Co-authored-by: Sergey Melnychuk <[email protected]>
@v-jizhang v-jizhang marked this pull request as draft March 10, 2022 19:16
@v-jizhang v-jizhang marked this pull request as ready for review September 13, 2022 22:28
@v-jizhang v-jizhang requested a review from a team as a code owner September 13, 2022 22:28
elharo
elharo approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but the CI hasn't fired. Can someone kick it off? Or maybe rebasing to master and pushing would kick ti off?

@elharo elharo requested a review from tdcmeehan September 29, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo approved these changes

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

@tdcmeehan tdcmeehan Awaiting requested review from tdcmeehan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-jizhang @elharo