Make sure that quoted identifiers remain quoted in formatter

[sergey-melnychuk]

The SqlFormatter effectively drops quotes from the quoted identifiers when formatting 'SET SESSION' statement (https://github.com/trinodb/trino/blob/master/core/trino-parser/src/main/java/io/trino/sql/SqlFormatter.java#L1514).

This causes valid queries to fail: e.g. SET SESSION "name-suffix".property = 'value' throws io.trino.spi.TrinoException: Formatted query does not parse even when identifier (name-suffix) is quoted.

[kasiafi]

SqlFormatter has a dedicated method for formatting QualifiedName:

trino/core/trino-parser/src/main/java/io/trino/sql/SqlFormatter.java

Line 168 in 7e99818

static String formatName(QualifiedName name)

It should be used to format SetSession's name (and some other QualifiedNamess, e.g. in ResetSession). That should fix the issue.

Please note that neither of the formatting solutions respects the proper identifier semantics. However, the method I suggest is closer and easier to fix, since it delegates the formatting to Identifier.

[sergey-melnychuk]

Thank you, @kasiafi , the SqlFormatter.formatName is exactly what I was looking for.

[kasiafi]

As a side-effect, this change alters the output of SqlFormatter regarding QualifiedNames in SetSession and ResetSession: before they were lowercased; after -- they are not.
It has no practical meaning, because the affected QualifiedNames are compared and resolved case-insensitive. However, please add this info to the commit message.

Many other Nodes have fields of type QualifiedName, too:
AddColumn
Analyze
Call
Comment
CreateMaterializedView
CreateSchema
CreateTable
CreateTableAsSelect
CreateView
Deny
DropColumn
DropMaterializedView
DropSchema
DropTable
DropView
FunctionCall
Grant
LikeClause
RenameColumn
RenameMaterializedView
RenameSchema
RenameTable
RenameView
ResetSession
Revoke
SetAuthorizationStatement
SetProperties
SetSession
ShowColumns
ShowCreate
Table
TruncateTable

Some of those are formatted with the formatName method, and some use toString. Could you please file an issue to check and fix the other occurrences in SqlFormatter and ExpressionFormatter?

[hashhar]

CI hit failure uploading test report to GitHub. nothing actually failed.