Release/1.x #175
Merged
Release/1.x #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one approach for handling default prettier arguments. It is a little verbose, but I think ejecting the flags that don't have to be set by the editor (in favor of .prettierrc files) is a win.
Start using prettier default arguments
- This is the first commit on refactoring methods outs on self contained components, this will help on unit testing and maintainability
- Refactoring parser out into its own module in order to make it easier to test
- Refactoring the executable resolver into its own module for making it easier to test
- Movingthe shiftwidth compat helper to a shim module responsible for dealing with backwards compatiblity
- prefer-file setting for config-precedence is what allow us to leverage from user defined configuration files like .prettierrc
- moving formating utils to buffer module to make it easier to interact and test
use buffered mode for neovim job
- adding facebook presets as a configurable option to overwrite prettier defaults
tests - printing vim version prior to running tests for debugging purposes
- fix test execution command and docker image ref
- the command is broken, but now we are able to reproduce the same output as in travis
- Updating Dockerfile to ensure we have a compatible vim version to vim-driver
- Docker image is now ready to be tested
enabling-tests-on-ci - Enabling tests as part of the CI run
- this updates the changelog for the previous last legacy release
- Adding Makefile - Updating travis to use Makefile - removing run script
moving-build-to-make-file - Adding build file
- Our previous undo implementation tried to be naive on implementing require-pragma, and created some undo bugs due to it. This diff enables us to use the prettier upstream support for require-pragma - On subsequent PR's we will completetly phase out the previous undo implementation in favour to this one in order to fix bug #184
requirePragma - This commit ensures that we use `prettier` default way to identify pragmas for the auto save and remove our previous naive implementation
Adding support for require-pragma and depracting previous naive implemenation
- when formatting files we should not trigger auto commands
- in order to bypass vimdefaults we can fake a change prior to formatting and merging that back to undostack operation
trigger autoformat
Issues/184 fixing undo step
default - This is a breaking change as on versions 0.x autoformat was enabled by default. This should ensure users dont need to disable autoformat anymore in their vimrc
- updating comment description to match new behaviour
…default making-auto-format-disabled-by-default - Making autoformat disabled by
Toggle the autoformat setting based on config file presence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the long lived branch PR for 1.x release
There are a few remaining tasks to be solved on it prior to release
fixes issue: #175