fix(p-menu): menu item visible flag logic (#17441)

Fixes: #17262 Co-authored-by: simone.boccato <[email protected]>
primefaces · Jan 29, 2025 · 70a6fb1 · 70a6fb1
1 parent ef391d5
commit 70a6fb1
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/packages/primeng/src/menu/menu.ts b/packages/primeng/src/menu/menu.ts
@@ -202,11 +202,10 @@ export class MenuItemContent {
                         <li class="p-menu-separator" *ngIf="item.separator && (item.visible !== false || submenu.visible !== false)" role="separator"></li>
                         <li
                             class="p-menu-item"
-                            *ngIf="!item.separator && (item.visible !== false || submenu.visible !== false)"
+                            *ngIf="!item.separator && item.visible !== false && (item.visible !== undefined || submenu.visible !== false)"
                             [pMenuItemContent]="item"
                             [itemTemplate]="itemTemplate ?? _itemTemplate"
                             [ngClass]="{
-                                'p-hidden': item.visible === false || submenu.visible === false,
                                 'p-focus': focusedOptionId() && menuitemId(item, id, i, j) === focusedOptionId(),
                                 'p-disabled': disabled(item.disabled)
                             }"
@@ -840,14 +839,7 @@ export class Menu extends BaseComponent implements AfterContentInit, OnDestroy {
     }
 
     hasSubMenu(): boolean {
-        if (this.model) {
-            for (var item of this.model) {
-                if (item.items) {
-                    return true;
-                }
-            }
-        }
-        return false;
+        return this.model?.some((item) => item.items) ?? false;
     }
 
     isItemHidden(item: any): boolean {