Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(p-menu): menu item visible flag logic #17441

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

Bock92
Copy link
Contributor

@Bock92 Bock92 commented Jan 20, 2025

Fixes: #17262

Changes made to fix the Issue:

  • Simplified the hasSubMenu() method for better readability and performance.
  • Update the submenu visibility condition to correctly handle edge cases.

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 8:34pm
primeng-v18 ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 8:34pm

Copy link

vercel bot commented Jan 20, 2025

Someone is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@mertsincan mertsincan merged commit 70a6fb1 into primefaces:master Jan 29, 2025
2 of 3 checks passed
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p-menu Nested MenuItem visible flag doesn't work on PrimeNG v19
2 participants