-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing deprecated column grid styles #662
Conversation
Ah, @jonrohan it looks like the test failed because this removes the '/objects/layout': removed, |
We're gonna push this PR for v12. Instead we're adding a warning #663 |
a7a0780
to
7860079
Compare
FYI, I'm queueing this up for inclusion in #887 (v13.0.0). 🎉 |
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-removecolumnstyles.primer.now.sh |
d52bcd8
to
ac31c56
Compare
As of 40bca3c, running the deprecations test script (see #889) yields:
I had to explicitly add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this!
This removes all the deprecated column grid styles.
.container
.column, .columns
one-half, etc...
@shawnbot
ref https://github.com/github/design-systems/issues/59